chore(onboarding): remove parallax #20026
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
J-Son89
requested review from
ilmotta,
cammellos,
shivekkhurana,
briansztamfater and
ulisesmac
J-Son89
changed the title
Jenkins BuildsClick to see older builds (13)
|
J-Son89
force-pushed
the
jc/remove-parallax
branch
from
ac2ec46
to
1d6fabc
Compare
ilmotta
approved these changes
May 15, 2024
shivekkhurana
approved these changes
May 15, 2024
This was referenced May 15, 2024
siddarthkay
reviewed
May 15, 2024
| (:require ["@walletconnect/react-native-compat"] | ||
| ["@walletconnect/core" :refer [Core]] | ||
| ["@walletconnect/web3wallet" :refer [Web3Wallet]] | ||
| (:require ["@walletconnect/core" :refer [Core]] |
There was a problem hiding this comment.
probably this change should be reverted in light of the comment above :
;; NOTE: Not sorting namespaces since @walletconnect/react-native-compat should be the first
There was a problem hiding this comment.
Aha, this is being done by the linter.
cc @ilmotta, @clauxx @briansztamfater - do we have a way to stop sorting automatically on some files? 🤔
There was a problem hiding this comment.
We do @J-Son89, but only if we stop linting the entire file. Check the line calling clojure-lsp <flags> clean-ns command in the lint-fix target. You can add another file there to be ignored.
|
Also 2 other things :
|
thanks @siddarthkay! |
J-Son89
force-pushed
the
jc/remove-parallax
branch
from
1d6fabc
to
a531733
Compare
J-Son89
force-pushed
the
jc/remove-parallax
branch
from
a531733
to
37bc24f
Compare
|
@siddarthkay - what do you think now? 🤔 |
siddarthkay
reviewed
May 15, 2024
jakubgs
approved these changes
May 15, 2024
|
@status-im/mobile-qa - what do you think about skipping QA here, I will do a happy path check myself too 👍 |
Sounds good, thank you @J-Son89 🙌 |
|
@qoqobolo - this seems to be fine on ios 12 previously whitelisted device - let me know about e2e results and I'll merge when it's all good 👍 |
81% of end-end tests have passedFailed tests (8)Click to expandClass TestGroupChatMultipleDeviceMergedNewUI:
Class TestDeepLinksOneDevice:
Class TestWalletMultipleDevice:
Class TestCommunityMultipleDeviceMerged:
Class TestActivityCenterContactRequestMultipleDevicePR:
Expected to fail tests (2)Click to expandClass TestGroupChatMultipleDeviceMergedNewUI:
Class TestCommunityOneDeviceMerged:
Passed tests (42)Click to expandClass TestGroupChatMultipleDeviceMergedNewUI:
Class TestCommunityMultipleDeviceMergedTwo:
Class TestActivityMultipleDevicePR:
Class TestWalletOneDevice:
Class TestCommunityMultipleDeviceMerged:
Class TestCommunityOneDeviceMerged:
Class TestOneToOneChatMultipleSharedDevicesNewUi:
Class TestActivityMultipleDevicePRTwo:
Class TestActivityCenterContactRequestMultipleDevicePR:
Class TestOneToOneChatMultipleSharedDevicesNewUiTwo:
|
|
@J-Son89 e2e look good, the failures are not related to PR. 
|
|
We forgot to add |
siddarthkay
added a commit
that referenced
this pull request
May 16, 2024
## Summary This commit fixes broken `make test-watch-for-repl` on MacOS. We make sure that default target is passed for this make command because the `node-pre-gyp` requires `python 3.1` This commit also adds the missing `yarn.lock` file which was missed in this PR #20026 This commit also modifies the `_test_clojure` command a bit to swap out its dependence on `status-go-library` since we do that on `yarn install` anyways. status: ready fixes: #20041
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The decision has been made to remove the parallax and animated videos.
There are many reasons for this, mostly summarised here: https://www.notion.so/3D-Animations-in-mobile-053f629f1a4541a69fb8054b3f384ddb
We will bake the cake first, the cherry can follow afterwards
Props again to @briansztamfater for coming up with this solution at the time! a lot of thought and effort went into it 🙌
I don't think this needs test as the fallback solution was already in place before.
Please let me know if I missed anything in the clean up.
fixes: #19987