-
Notifications
You must be signed in to change notification settings - Fork 982
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add swap option in wallet action drawer #20029
Conversation
Jenkins BuildsClick to see older builds (4)
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
87% of end-end tests have passed
Failed tests (5)Click to expandClass TestGroupChatMultipleDeviceMergedNewUI:
Class TestDeepLinksOneDevice:
Class TestWalletMultipleDevice:
Expected to fail tests (2)Click to expandClass TestGroupChatMultipleDeviceMergedNewUI:
Class TestCommunityOneDeviceMerged:
Passed tests (45)Click to expandClass TestActivityMultipleDevicePR:
Class TestCommunityOneDeviceMerged:
Class TestActivityCenterContactRequestMultipleDevicePR:
Class TestOneToOneChatMultipleSharedDevicesNewUiTwo:
Class TestOneToOneChatMultipleSharedDevicesNewUi:
Class TestCommunityMultipleDeviceMergedTwo:
Class TestCommunityMultipleDeviceMerged:
Class TestGroupChatMultipleDeviceMergedNewUI:
Class TestWalletOneDevice:
Class TestActivityMultipleDevicePRTwo:
|
@status-im/mobile-qa The changes in this PR are under the swap feature flag, so we can skip manual qa. Could you please check the E2E results and let me know if we are good to merge? |
f5660a8
to
d51149f
Compare
Hi @ajayesivan, thanks for the PR! E2e failures are known and not related |
d51149f
to
184335c
Compare
fixes #20028
Add swap option in the wallet action drawer.
Testing notes
This change is under the 'swap' feature flag. Enable 'swap' flag under Settings -> Feature Flags to test.
We can skip manual QA since this feature is under the swap feature flag.
Steps to test
Screenshot
status: ready