Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: balances in network preferences after removing account #20139

Merged
merged 6 commits into from
May 23, 2024
Merged

fix: balances in network preferences after removing account #20139

merged 6 commits into from
May 23, 2024

Conversation

OmarBasem
Copy link
Member

@OmarBasem OmarBasem commented May 22, 2024 •
edited

fixes: #19542

Summary

This PR fixes balances not showing in network preferences after removing an account.

Also fixes wallet/close-account-page not being called if back button was pressed (or swipe gesture) instead of pressing on the X button

On a side note: I think we need to check for X button on-press if it is called on unmount in the entire wallet/app

Demo

Screen_Recording_20240522_111217_Status.mp4

@OmarBasem OmarBasem self-assigned this May 22, 2024
@status-github-bot status-github-bot bot added this to REVIEW in Pipeline for QA May 22, 2024
@OmarBasem OmarBasem changed the title fixes: balances in network preferences after removing account fix: balances in network preferences after removing account May 22, 2024
@status-im-auto
Copy link
Member

status-im-auto commented May 22, 2024 •
edited

Jenkins Builds

Click to see older builds (14)
❔ Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ c1d9332 #1 2024-05-22 07:23:11 ~4 min tests 📄log
✔️ c1d9332 #1 2024-05-22 07:24:52 ~6 min android 🤖apk 📲
✔️ c1d9332 #1 2024-05-22 07:25:57 ~7 min android-e2e 🤖apk 📲
✔️ c1d9332 #1 2024-05-22 07:28:39 ~10 min ios 📱ipa 📲
❌ 25b578a #3 2024-05-22 07:48:08 ~4 min tests 📄log
✔️ 25b578a #3 2024-05-22 07:52:11 ~8 min android-e2e 🤖apk 📲
✔️ 7efa1a0 #4 2024-05-22 07:57:31 ~4 min tests 📄log
✔️ 7efa1a0 #4 2024-05-22 08:01:07 ~8 min android-e2e 🤖apk 📲
✔️ 7efa1a0 #4 2024-05-22 08:01:16 ~8 min android 🤖apk 📲
✔️ 7efa1a0 #4 2024-05-22 08:02:25 ~9 min ios 📱ipa 📲
✔️ 4bf7cf1 #6 2024-05-22 12:23:49 ~9 min ios 📱ipa 📲
✔️ 4bf7cf1 #6 2024-05-22 12:26:24 ~11 min tests 📄log
✔️ 4bf7cf1 #6 2024-05-22 12:27:25 ~12 min android-e2e 🤖apk 📲
✔️ 4bf7cf1 #6 2024-05-22 12:29:00 ~14 min android 🤖apk 📲
❔ Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ 1d58083 #7 2024-05-23 11:01:58 ~4 min tests 📄log
✔️ 1d58083 #7 2024-05-23 11:06:01 ~8 min android 🤖apk 📲
✔️ 1d58083 #7 2024-05-23 11:06:01 ~8 min android-e2e 🤖apk 📲
✔️ 1d58083 #7 2024-05-23 11:07:23 ~9 min ios 📱ipa 📲
✔️ 05d4667 #8 2024-05-23 13:08:31 ~4 min tests 📄log
✔️ 05d4667 #8 2024-05-23 13:12:43 ~8 min android-e2e 🤖apk 📲
✔️ 05d4667 #8 2024-05-23 13:12:45 ~8 min android 🤖apk 📲
✔️ 05d4667 #8 2024-05-23 13:14:02 ~9 min ios 📱ipa 📲

@OmarBasem OmarBasem force-pushed the fix/balances-after-remove-account branch from 7efa1a0 to 76de722 Compare May 22, 2024 12:13
@OmarBasem OmarBasem requested review from J-Son89 and BalogunofAfrica and removed request for J-Son89 May 22, 2024 15:50
@OmarBasem OmarBasem moved this from REVIEW to E2E Tests in Pipeline for QA May 23, 2024
@status-im-auto
Copy link
Member

88% of end-end tests have passed

Total executed tests: 52
Failed tests: 3
Expected to fail tests: 3
Passed tests: 46

IDs of failed tests: 727230,727229,727232 

IDs of expected to fail tests: 703495,703503,702807

Failed tests (3)

Click to expand
  • Rerun failed tests

    • Class TestWalletMultipleDevice:

    1. test_wallet_send_asset_from_drawer, id: 727230 
    critical/test_wallet.py:119: in test_wallet_send_asset_from_drawer
    self.wallet_view.navigate_back_to_wallet_view()
 'TestWalletMultipleDevice' object has no attribute 'wallet_view'



    2. test_wallet_send_eth, id: 727229

    Device 1: Tap on found: LogInButton
    Device 1: Find Button by accessibility id: done 

    critical/test_wallet.py:111: in test_wallet_send_eth
    self.wallet_1.send_asset(address=self.receiver['address'], asset_name='Ether', amount=amount_to_send)
../views/wallet_view.py:100: in send_asset
    self.confirm_transaction()
../views/wallet_view.py:88: in confirm_transaction
    self.done_button.click()
../views/base_element.py:90: in click
    element = self.find_element()
../views/base_element.py:79: in find_element
    raise NoSuchElementException(
 Device 1: Button by accessibility id: `done` is not found on the screen; For documentation on this error, please visit: https://www.selenium.dev/documentation/webdriver/troubleshooting/errors#no-such-element-exception



    Class TestWalletOneDevice:

    1. test_wallet_add_remove_watch_only_account, id: 727232

    Device 1: Text is 0x8d2413447ff297d30bdc475f6d5cb00254685aae
    Device 1: Click system back button 

    critical/test_wallet.py:213: in test_wallet_add_remove_watch_only_account
    self.home_view.driver.fail(
base_test_case.py:178: in fail
    pytest.fail('Device %s: %s' % (self.number, text))
 Device 1: Incorrect address '0x8d2413447ff297d30bdc475f6d5cb00254685aae' is shown when swiping between accounts, expected one is '0x8d2413447ff297d30bdc475f6d5cb00254685aae'



    Device sessions

    Expected to fail tests (3)

    Click to expand

    Class TestGroupChatMultipleDeviceMergedNewUI:

    1. test_group_chat_mute_chat, id: 703495

    # STEP: Change device time so chat will be unmuted by timer
    Device 2: Long press on ChatElement 

    critical/chats/test_group_chat.py:466: in test_group_chat_mute_chat
    self.errors.verify_no_errors()
base_test_case.py:190: in verify_no_errors
    pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))]))
 Chat is still muted after timeout

    [[Chat is not unmuted after expected time: https://github.com//issues/19627]]

    Device sessions

    2. test_group_chat_join_send_text_messages_push, id: 702807

    Device 2: Find Text by xpath: //*[starts-with(@text,'Hey, admin!')]/ancestor::android.view.ViewGroup[@content-desc='chat-item']//*[@content-desc='message-status']/android.widget.TextView
    Device 2: Text is Sent 

    critical/chats/test_group_chat.py:97: in test_group_chat_join_send_text_messages_push
    self.chats[1].chat_element_by_text(message_to_admin).wait_for_status_to_be('Delivered', timeout=120)
../views/chat_view.py:225: in wait_for_status_to_be
    raise TimeoutException("Message status was not changed to %s, it's %s" % (expected_status, current_status))
 Message status was not changed to Delivered, it's Sent

    [[Issue with a message status - Sent instead of Delivered, https://github.com//issues/20126]]

    Device sessions

    Class TestCommunityOneDeviceMerged:

    1. test_community_discovery, id: 703503 

    Test is not run, e2e blocker

    [[reason: [NOTRUN] Curated communities not loading, https://github.com//issues/17852]]

    Passed tests (46)

    Click to expand

    Class TestCommunityMultipleDeviceMerged:

    1. test_community_several_images_send_reply, id: 703194
    Device sessions

    2. test_community_one_image_send_reply, id: 702859
    Device sessions

    3. test_community_emoji_send_copy_paste_reply, id: 702840
    Device sessions

    4. test_community_mark_all_messages_as_read, id: 703086
    Device sessions

    5. test_community_contact_block_unblock_offline, id: 702894
    Device sessions

    6. test_community_edit_delete_message_when_offline, id: 704615
    Device sessions

    7. test_community_message_delete, id: 702839
    Device sessions

    8. test_community_message_send_check_timestamps_sender_username, id: 702838
    Device sessions

    9. test_community_links_with_previews_github_youtube_twitter_gif_send_enable, id: 702844
    Device sessions

    10. test_community_message_edit, id: 702843
    Device sessions

    11. test_community_unread_messages_badge, id: 702841
    Device sessions

    Class TestOneToOneChatMultipleSharedDevicesNewUi:

    1. test_1_1_chat_emoji_send_reply_and_open_link, id: 702782
    Device sessions

    2. test_1_1_chat_text_message_delete_push_disappear, id: 702733
    Device sessions

    3. test_1_1_chat_push_emoji, id: 702813
    Device sessions

    4. test_1_1_chat_non_latin_messages_stack_update_profile_photo, id: 702745
    Device sessions

    5. test_1_1_chat_edit_message, id: 702855
    Device sessions

    6. test_1_1_chat_send_image_save_and_share, id: 703391
    Device sessions

    7. test_1_1_chat_pin_messages, id: 702731
    Device sessions

    8. test_1_1_chat_message_reaction, id: 702730
    Device sessions

    Class TestActivityCenterContactRequestMultipleDevicePR:

    1. test_add_contact_field_validation, id: 702777
    Device sessions

    2. test_activity_center_contact_request_accept_swipe_mark_all_as_read, id: 702851
    Device sessions

    3. test_activity_center_contact_request_decline, id: 702850
    Device sessions

    Class TestWalletOneDevice:

    1. test_wallet_add_remove_regular_account, id: 727231
    Device sessions

    Class TestDeepLinksOneDevice:

    1. test_links_open_universal_links_from_chat, id: 704613
    Device sessions

    2. test_links_deep_links, id: 702775
    Device sessions

    Class TestOneToOneChatMultipleSharedDevicesNewUiTwo:

    1. test_1_1_chat_delete_via_long_press_relogin, id: 702784
    Device sessions

    2. test_1_1_chat_is_shown_message_sent_delivered_from_offline, id: 702783
    Device sessions

    3. test_1_1_chat_mute_chat, id: 703496
    Device sessions

    Class TestCommunityMultipleDeviceMergedTwo:

    1. test_community_markdown_support, id: 702809
    Device sessions

    2. test_community_hashtag_links_to_community_channels, id: 702948
    Device sessions

    3. test_community_mentions_push_notification, id: 702786
    Device sessions

    4. test_community_leave, id: 702845
    Device sessions

    5. test_community_join_when_node_owner_offline, id: 703629
    Device sessions

    Class TestGroupChatMultipleDeviceMergedNewUI:

    1. test_group_chat_pin_messages, id: 702732
    Device sessions

    2. test_group_chat_send_image_save_and_share, id: 703297
    Device sessions

    3. test_group_chat_reactions, id: 703202
    Device sessions

    4. test_group_chat_offline_pn, id: 702808
    Device sessions

    Class TestActivityMultipleDevicePRTwo:

    1. test_activity_center_mentions, id: 702957
    Device sessions

    2. test_activity_center_admin_notification_accept_swipe, id: 702958
    Device sessions

    Class TestCommunityOneDeviceMerged:

    1. test_restore_multiaccount_with_waku_backup_remove_switch, id: 703133
    Device sessions

    2. test_community_copy_and_paste_message_in_chat_input, id: 702742
    Device sessions

    3. test_community_undo_delete_message, id: 702869
    Device sessions

    4. test_community_navigate_to_channel_when_relaunch, id: 702846
    Device sessions

    5. test_community_mute_community_and_channel, id: 703382
    Device sessions

    Class TestActivityMultipleDevicePR:

    1. test_navigation_jump_to, id: 702936
    Device sessions

    2. test_activity_center_reply_read_unread_delete_filter_swipe, id: 702947
    Device sessions

    @mariia-skrypnyk mariia-skrypnyk moved this from E2E Tests to IN TESTING in Pipeline for QA May 23, 2024
    @mariia-skrypnyk mariia-skrypnyk self-assigned this May 23, 2024
    @mariia-skrypnyk mariia-skrypnyk force-pushed the fix/balances-after-remove-account branch from 4bf7cf1 to 1d58083 Compare May 23, 2024 10:57
    @mariia-skrypnyk
    Copy link

    Hi @OmarBasem !

    Thanks for your fix!
    I've checked it on both platforms and it looks good 🙌.
    Failed e2e are not related.
    So, PR can be merged.

    @mariia-skrypnyk mariia-skrypnyk moved this from IN TESTING to MERGE in Pipeline for QA May 23, 2024
    @OmarBasem OmarBasem force-pushed the fix/balances-after-remove-account branch from 1d58083 to 05d4667 Compare May 23, 2024 13:03
    @OmarBasem OmarBasem merged commit d2fb6c7 into develop May 23, 2024
    6 checks passed
    Pipeline for QA automation moved this from MERGE to DONE May 23, 2024
    @OmarBasem OmarBasem deleted the fix/balances-after-remove-account branch May 23, 2024 13:52
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Reviewers

    @BalogunofAfrica BalogunofAfrica BalogunofAfrica approved these changes

    @vkjr vkjr Awaiting requested review from vkjr

    @briansztamfater briansztamfater Awaiting requested review from briansztamfater

    @mmilad75 mmilad75 Awaiting requested review from mmilad75

    @ulisesmac ulisesmac Awaiting requested review from ulisesmac

    @J-Son89 J-Son89 Awaiting requested review from J-Son89

    Assignees

    @OmarBasem OmarBasem

    @mariia-skrypnyk mariia-skrypnyk

    Labels
    request-manual-qa Tested - OK
    Projects
    Pipeline for QA
      
    DONE
    Pipeline for QA
    Status: DONE
    Milestone
    No milestone
    Development

    Successfully merging this pull request may close these issues.

    The balances are not shown in network preferences when the account with some assets is removed
    4 participants
    @OmarBasem @status-im-auto @mariia-skrypnyk @BalogunofAfrica