You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OmarBasem
changed the title
fixes: balances in network preferences after removing account
fix: balances in network preferences after removing account
May 22, 2024
critical/test_wallet.py:119: in test_wallet_send_asset_from_drawer
self.wallet_view.navigate_back_to_wallet_view()
'TestWalletMultipleDevice' object has no attribute 'wallet_view'
critical/test_wallet.py:111: in test_wallet_send_eth
self.wallet_1.send_asset(address=self.receiver['address'], asset_name='Ether', amount=amount_to_send)
../views/wallet_view.py:100: in send_asset
self.confirm_transaction()
../views/wallet_view.py:88: in confirm_transaction
self.done_button.click()
../views/base_element.py:90: in click
element = self.find_element()
../views/base_element.py:79: in find_element
raise NoSuchElementException(
Device 1: Button by accessibility id: `done` is not found on the screen; For documentation on this error, please visit: https://www.selenium.dev/documentation/webdriver/troubleshooting/errors#no-such-element-exception
Device 1: Text is 0x8d2413447ff297d30bdc475f6d5cb00254685aae
Device 1: Click system back button
critical/test_wallet.py:213: in test_wallet_add_remove_watch_only_account
self.home_view.driver.fail(
base_test_case.py:178: in fail
pytest.fail('Device %s: %s' % (self.number, text))
Device 1: Incorrect address '0x8d2413447ff297d30bdc475f6d5cb00254685aae' is shown when swiping between accounts, expected one is '0x8d2413447ff297d30bdc475f6d5cb00254685aae'
# STEP: Change device time so chat will be unmuted by timer
Device 2: Long press on ChatElement
critical/chats/test_group_chat.py:466: in test_group_chat_mute_chat
self.errors.verify_no_errors()
base_test_case.py:190: in verify_no_errors
pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))]))
Chat is still muted after timeout
[[Chat is not unmuted after expected time: https://github.com//issues/19627]]
Device 2: Find Text by xpath: //*[starts-with(@text,'Hey, admin!')]/ancestor::android.view.ViewGroup[@content-desc='chat-item']//*[@content-desc='message-status']/android.widget.TextView
Device 2: Text is Sent
critical/chats/test_group_chat.py:97: in test_group_chat_join_send_text_messages_push
self.chats[1].chat_element_by_text(message_to_admin).wait_for_status_to_be('Delivered', timeout=120)
../views/chat_view.py:225: in wait_for_status_to_be
raise TimeoutException("Message status was not changed to %s, it's %s" % (expected_status, current_status))
Message status was not changed to Delivered, it's Sent
[[Issue with a message status - Sent instead of Delivered, https://github.com//issues/20126]]
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes: #19542
Summary
This PR fixes balances not showing in network preferences after removing an account.
Also fixes
wallet/close-account-page
not being called if back button was pressed (or swipe gesture) instead of pressing on the X buttonOn a side note: I think we need to check for X button on-press if it is called on unmount in the entire wallet/app
Demo
Screen_Recording_20240522_111217_Status.mp4