[WIP] Command scopes fixes: #2061, #2072, #2075 #2129
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rasom
approved these changes
Oct 12, 2017
yenda
suggested changes
Oct 12, 2017
| @@ -1,7 +1,7 @@ | |||
| { | |||
| "name": "StatusIm", | |||
| "interface": "reagent", | |||
| "androidHost": "localhost", | |||
| "androidHost": "10.0.3.2", | |||
There was a problem hiding this comment.
it's still in progress, it doesn't suppose to be merged right now
There was a problem hiding this comment.
my bad, makes me realize the status we usually put in the PR description (ready/wip) is redundant with the column in zenhub
|
Is this going to be squashed in the other PR ? Why is it in a separate PR ? |
alwx
force-pushed
the
feature/command-scopes
branch
from
d71e7a3
to
a958c32
Compare
alwx
force-pushed
the
bug/command-scopes-fixes
branch
from
34bf465
to
c45457a
Compare
alwx
force-pushed
the
bug/command-scopes-fixes
branch
from
c45457a
to
2308d19
Compare
alwx
force-pushed
the
feature/command-scopes
branch
from
a958c32
to
ca93238
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2061, #2072, #2075