Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No Unsigned Transaction screen is shown if send tx in chat with 2 members [feature/command-scopes] #2061

Closed
annadanchenko opened this issue Oct 9, 2017 · 1 comment
Assignees
Milestone

Comments

@annadanchenko
Copy link

Description

Type: Bug

Summary:
User can't send a transaction in group chat with 2 members because Unsigned transaction screen is not shown after tap on send button. Instead, same chat is shown with nothing in the input field

Expected behavior

If send command gets valid parameters and user taps on send button then Unsigned transaction screen is shown

Actual behavior

same chat is shown with nothing in the input field

Reproduction

(from 00:41) https://app.testfairy.com/projects/4803622-status/builds/6783719/sessions/8/?accessToken=ONT3syhpY2Zo72TKoD0cPycUZQM

  • Open Status
  • Create group chat with 1 member, so in total there are 2 members: you and e.g. Jarrad
  • In group chat tap on send command. Note that there is no suggestions shown
  • type valid amount and tap on send button

Additional Information

  • Status version: feature/command-scopes 0.9.10-175-g9a4ef51a
  • Operating System:
    Real device iPhone 7 plus, iOs 11.0.2
    Real device Google Pixel XL, Android 8.0
@asemiankevich
Copy link
Contributor

This is fixed in 0.9.10-215-g45b94306+ both android and ios

alwx added a commit that referenced this issue Oct 16, 2017
rasom pushed a commit that referenced this issue Oct 16, 2017
alwx added a commit that referenced this issue Oct 16, 2017
cammellos added a commit that referenced this issue May 26, 2021
Fixes: #2061

This commit adds an unread mentions count in 3 places:

1) Public chats
2) Communities in home
3) Communities chats

The logic is that if you have unread mentions, it will show you the
count of messages with unread mentions, while if you have only unread
messages, you will see a blue dot.
cammellos added a commit that referenced this issue May 26, 2021
Fixes: #2061

This commit adds an unread mentions count in 3 places:

1) Public chats
2) Communities in home
3) Communities chats

The logic is that if you have unread mentions, it will show you the
count of messages with unread mentions, while if you have only unread
messages, you will see a blue dot.
cammellos added a commit that referenced this issue May 27, 2021
Fixes: #2061

This commit adds an unread mentions count in 3 places:

1) Public chats
2) Communities in home
3) Communities chats

The logic is that if you have unread mentions, it will show you the
count of messages with unread mentions, while if you have only unread
messages, you will see a blue dot.
cammellos added a commit that referenced this issue May 27, 2021
Fixes: #2061

This commit adds an unread mentions count in 3 places:

1) Public chats
2) Communities in home
3) Communities chats

The logic is that if you have unread mentions, it will show you the
count of messages with unread mentions, while if you have only unread
messages, you will see a blue dot.
cammellos added a commit that referenced this issue May 28, 2021
Fixes: #2061

This commit adds an unread mentions count in 3 places:

1) Public chats
2) Communities in home
3) Communities chats

The logic is that if you have unread mentions, it will show you the
count of messages with unread mentions, while if you have only unread
messages, you will see a blue dot.
cammellos added a commit that referenced this issue May 28, 2021
Fixes: #2061

This commit adds an unread mentions count in 3 places:

1) Public chats
2) Communities in home
3) Communities chats

The logic is that if you have unread mentions, it will show you the
count of messages with unread mentions, while if you have only unread
messages, you will see a blue dot.
cammellos added a commit that referenced this issue May 28, 2021
Fixes: #2061

This commit adds an unread mentions count in 3 places:

1) Public chats
2) Communities in home
3) Communities chats

The logic is that if you have unread mentions, it will show you the
count of messages with unread mentions, while if you have only unread
messages, you will see a blue dot.

Signed-off-by: Andrea Maria Piana <andrea.maria.piana@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants