[ISSUE #3083] Adapted chat menu to latest mockups #3308
Conversation
src/status_im/chat/screen.cljs
Outdated
| creating? [:get :accounts/creating-account?] | ||
| group-chat? [:chat :group-chat] | ||
| chat-name [:chat :name] | ||
| chat-id [:chat :chat-id]] |
There was a problem hiding this comment.
Why so many subscriptions, isn't better and more effective to just use [:get-current-chat] and destructure the necessary properties ?
We are eventually trying to get rid of the general :get/:set subs and events as they are anti-pattern (clearly stated in re-frame guide), so it would be best to not add them in new code.
There was a problem hiding this comment.
Didn't change the original design as this is more a UI PR.
Do you think we have all details with get-current-chat ?
There was a problem hiding this comment.
No problem with that, that's why I didn't requested changes, just mentioned it.
It would also save us 2 lines of code, being:
{:keys [group-chat name chat-id} [:get-current-chat]Instead of those three lines.
jeluard
force-pushed
the
feature/#3083
branch
from
4e37e1a
to
8221f35
Compare
|
@janherich Updated |
yenda
changed the title
|
smaller suggestions area is shown |
|
just a small reminder: this PR introduces a lot of changes for suggestions area #3259 |
|
first check 3259 when it’s ready. |
Signed-off-by: Julien Eluard <julien.eluard@gmail.com>
jeluard
force-pushed
the
feature/#3083
branch
from
8221f35
to
058e6c5
Compare
fixes #3083
Summary:
Adapt chat menu to reflect latest mockups
Steps to test:
status: ready