Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX #3341] chat, translations, ui: fix chat delete confirmation #3376

Conversation

ihor-lev
Copy link
Contributor

Summary:

Add delete confirmation window for all the available cases:

  • Delete chat
  • Leave group
  • Leave group (in group settings)

Review notes (optional):

The PR should be coordinated with #3308.

status: ready

@status-github-bot status-github-bot bot added this to REVIEW in Pipeline for QA Feb 19, 2018
@jeluard
Copy link
Contributor

jeluard commented Feb 20, 2018

@ikysylevych Thanks for the contribution!

We have a special re-frame fx for this: show-confirmation.
I already implemented it in the PR I am working on.

Hopefully you can continue contributing anyway? I suggest to take a look at the issues with the bounty label.

@ihor-lev
Copy link
Contributor Author

@jeluard Thanks! No problem. So I'm closing this PR.

@ihor-lev ihor-lev closed this Feb 20, 2018
Pipeline for QA automation moved this from REVIEW to DONE Feb 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

2 participants