Migrate figwheel conf from project.clj to figwheel ns #3358
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @voxlet, thanks for making your first pull request in status-react! ❤️ |
jeluard
reviewed
Feb 19, 2018
env/dev/figwheel.clj
Outdated
|
|
||
| (defn get-build [builds id] | ||
| (when-let [build (first (filter #(= (:id %) (get-id id)) builds))] | ||
| (if (test-id? id) |
There was a problem hiding this comment.
Is this part still relevant? If not we could simply remove it.
There was a problem hiding this comment.
Not that I can see, at least in terms of immediate code dependency. It was kept for the case of everyday REPL session use, but as far as I can tell the *-test runs are already broken in develop.
Maybe we can go ahead and delete the code, and see if there any complaints? I think the chances of that happening are low enough.
dmitryn
approved these changes
Feb 19, 2018
jeluard
approved these changes
Feb 20, 2018
|
@voxlet please squash commits |
voxlet
force-pushed
the
feature/simplify-figwheel-config-#2999
branch
from
434ddd0
to
fd3cc86
Compare
Signed-off-by: Julien Eluard <julien.eluard@gmail.com>
jeluard
force-pushed
the
feature/simplify-figwheel-config-#2999
branch
from
fd3cc86
to
fad4750
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2999
Summary:
Replaced the figwheel profile :cljsbuild section with the equivalent in figwheel.edn format (along with the config reshaping code in figwheel-api), making sure not to change the behavior of
figwheel-api/start.Review notes (optional):
I erred on the conservative side with the changes, preserving the *-test builds and warning-handler in the android build.
Steps to test:
lein figwheel-replbehavior has not changedstatus: ready