-
Notifications
You must be signed in to change notification settings - Fork 984
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate figwheel conf from project.clj to figwheel ns #3358
Migrate figwheel conf from project.clj to figwheel ns #3358
Conversation
Hey @voxlet, thanks for making your first pull request in status-react! ❤️ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks looks great!
env/dev/figwheel.clj
Outdated
|
||
(defn get-build [builds id] | ||
(when-let [build (first (filter #(= (:id %) (get-id id)) builds))] | ||
(if (test-id? id) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this part still relevant? If not we could simply remove it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not that I can see, at least in terms of immediate code dependency. It was kept for the case of everyday REPL session use, but as far as I can tell the *-test runs are already broken in develop.
Maybe we can go ahead and delete the code, and see if there any complaints? I think the chances of that happening are low enough.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please remove it then! :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution!
@voxlet please squash commits |
434ddd0
to
fd3cc86
Compare
Signed-off-by: Julien Eluard <julien.eluard@gmail.com>
fd3cc86
to
fad4750
Compare
Fixes #2999
Summary:
Replaced the figwheel profile :cljsbuild section with the equivalent in figwheel.edn format (along with the config reshaping code in figwheel-api), making sure not to change the behavior of
figwheel-api/start
.Review notes (optional):
I erred on the conservative side with the changes, preserving the *-test builds and warning-handler in the android build.
Steps to test:
lein figwheel-repl
behavior has not changedstatus: ready