-
Notifications
You must be signed in to change notification settings - Fork 984
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert "Fix #3013 Swipe chat based deletion" #3390
Conversation
@yenda @antdanchenko @flexsurfer "The commit is breaking home screen" - any idea on why automated tests didn't catch this / why it was merged anyway / how we can avoid this future? |
Automated test results:test_contact_profile_view:x:Test Steps & Error message:
test_transaction_send_command_group_chat:x:Test Steps & Error message:
test_transaction_send_command_one_to_one_chat:white_check_mark::Test Steps & Error message:
test_public_chat:x:Test Steps & Error message:
test_send_eth_from_wallet_sign_later:x:Test Steps & Error message:
test_one_to_one_chat_messages_and_delete_chat:x:Test Steps & Error message:
test_browse_link_entering_url_in_dapp_view:x:Test Steps & Error message:
test_send_transaction_from_daap:white_check_mark::Test Steps & Error message:
test_group_chat_messages:x:Test Steps & Error message:
test_send_stt_from_wallet_via_enter_contact_code:x:Test Steps & Error message:
test_transaction_send_command_wrong_password:x:Test Steps & Error message:
test_send_eth_to_request_in_one_to_one_chat:x:Test Steps & Error message:
test_send_eth_to_request_from_wallet:white_check_mark::Test Steps & Error message:
|
b5a0929
to
cc8ef65
Compare
This reverts commit f4f1ab4.
The commit is breaking home screen
This is current develop:
you can check Branch: PR-3389
Android: https://i.diawi.com/H2GYbu
iOS: https://i.diawi.com/gkq9aF
This is this branch:
Branch: PR-3390
Android: https://i.diawi.com/QNi99t
iOS: https://i.diawi.com/YP8Qoo
I checked at least for Android
Note for testers: no need to test this it's a revert
Status: ready