Check if package-lock.json was changed and fail the build (Mobile only) #6915
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Checklist
|
mandrigin
requested review from
pedropombeiro,
jakubgs,
corpetty,
rasom and
yenda
ci/common.groovy
Outdated
| @@ -53,14 +53,20 @@ def installJSDeps(platform) { | |||
| def attempt = 1 | |||
| def maxAttempts = 10 | |||
| def installed = false | |||
| def errroCode = 0 | |||
|
Output for |
mandrigin
commented
Nov 28, 2018
| @@ -8791,7 +8791,9 @@ | |||
| } | |||
| }, | |||
| "react-native-http-bridge": { | |||
| "version": "git+https://github.com/status-im/react-native-http-bridge.git#214301a806743d0ce04f4559c3d55b3e8ff95f5d" | |||
There was a problem hiding this comment.
@flexsurfer @yenda so we have switched from our own fork of the react-native-http-bridge back to the npm version, right?
mandrigin
changed the title
3 tasks
mandrigin
changed the title
pedropombeiro
approved these changes
Nov 28, 2018
rasom
approved these changes
Nov 28, 2018
|
Continuing my adventures. |
|
I know we tried moving to yarn before and abandoned that for some reason, but haven't come across a write-up of what happened. It does seem to be something we'd want to do sooner rather than later, especially before Reproducible Builds. |
|
Okay, I will try to switch us to Yarn, let's close this PR for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to vulnerabilities, like the one found in event-stream, we can't trust npm even when locking the version numbers.
Hence, we are trying to mitigate similar issues by checking if
package-lock.jsonwas updated afternpm installand failing the build if it was.The lock file contains a checksum of the minified package, so if someone updates it but keeps the same version, this script should detect it.
package-lock.jsoncontentnpm installpackage.jsonare lockedfixes #6906
status: ready