Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[iOS] Allow to send email with logs on iOS #8124

Merged
merged 1 commit into from May 14, 2019
Merged

[iOS] Allow to send email with logs on iOS #8124

merged 1 commit into from May 14, 2019

Conversation

rasom
Copy link
Member

@rasom rasom commented May 3, 2019 •
edited by StatusWrike

fetching status-go logs using StatusgoExportNodeLogs() will be added in the separate PR, requires status-go update so might take some extra time

status: ready

@status-github-bot
Copy link

Pull Request Checklist

  • Have you updated the documentation, if impacted (e.g. docs.status.im)?

@status-github-bot status-github-bot bot added this to REVIEW in Pipeline for QA May 3, 2019
@rasom rasom self-assigned this May 3, 2019
@status-im-auto
Copy link
Member

status-im-auto commented May 3, 2019 •
edited

Jenkins Builds

Click to see older builds (46)
❔ Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ 7bcd7ab #1 2019-05-03 14:41:26 ~18 min macos 📦 dmg
✔️ 7bcd7ab #1 2019-05-03 14:44:48 ~21 min linux 📦 App
✔️ 7bcd7ab #1 2019-05-03 14:47:05 ~23 min windows 📦 exe
✔️ 7bcd7ab #1 2019-05-03 14:50:28 ~27 min ios 📦 ipa
✔️ 7bcd7ab #1 2019-05-03 14:51:15 ~28 min android-e2e 📦 apk
✔️ 7bcd7ab #1 2019-05-03 14:52:19 ~29 min android 📦 apk
❌ c39ee2d #2 2019-05-04 05:15:54 ~31 sec android-e2e 📄 log
❌ c39ee2d #2 2019-05-04 05:15:54 ~29 sec android 📄 log
❌ c39ee2d #2 2019-05-04 05:15:54 ~28 sec ios 📄 log
❌ c39ee2d #2 2019-05-04 05:15:59 ~31 sec windows 📄 log
❌ c39ee2d #2 2019-05-04 05:15:59 ~32 sec linux 📄 log
❌ c39ee2d #2 2019-05-04 05:16:00 ~33 sec macos 📄 log
❌ dd1f8cd #3 2019-05-04 05:30:04 ~53 sec linux 📄 log
❌ dd1f8cd #3 2019-05-04 05:30:38 ~1 min windows 📄 log
✔️ dd1f8cd #3 2019-05-04 05:45:07 ~15 min macos 📦 dmg
✔️ dd1f8cd #3 2019-05-04 05:48:23 ~19 min android 📦 apk
✔️ dd1f8cd #3 2019-05-04 05:55:59 ~26 min ios 📦 ipa
❌ a320c9f #4 2019-05-05 05:37:03 ~58 sec linux 📄 log
❌ a320c9f #4 2019-05-05 05:37:03 ~57 sec windows 📄 log
✔️ a320c9f #4 2019-05-05 05:53:06 ~17 min macos 📦 dmg
✔️ a320c9f #4 2019-05-05 05:55:27 ~19 min android 📦 apk
✔️ a320c9f #4 2019-05-05 05:59:52 ~23 min ios 📦 ipa
✔️ 7bd83af #6 2019-05-06 06:38:15 ~17 min linux 📦 App
✔️ 7bd83af #6 2019-05-06 06:38:41 ~17 min macos 📦 dmg
✔️ 7bd83af #6 2019-05-06 06:39:07 ~17 min windows 📦 exe
❌ 7bd83af #6 2019-05-06 06:39:58 ~18 min android 📄 log
✔️ 7bd83af #6 2019-05-06 06:47:33 ~26 min android-e2e 📦 apk
✔️ 7bd83af #6 2019-05-06 06:48:39 ~27 min ios 📦 ipa
✔️ e3bf46e #7 2019-05-07 11:54:43 ~27 min macos 📦 dmg
✔️ e3bf46e #7 2019-05-07 11:56:23 ~29 min android-e2e 📦 apk
✔️ e3bf46e #7 2019-05-07 11:57:55 ~30 min windows 📦 exe
✔️ e3bf46e #7 2019-05-07 12:00:37 ~33 min linux 📦 App
✔️ e3bf46e #7 2019-05-07 12:00:39 ~33 min ios 📦 ipa
✔️ e3bf46e #7 2019-05-07 12:03:56 ~36 min android 📦 apk
✔️ c8a77f4 #8 2019-05-12 15:35:25 ~16 min windows 📦 exe
✔️ c8a77f4 #8 2019-05-12 15:35:58 ~16 min linux 📦 App
✔️ c8a77f4 #8 2019-05-12 15:38:07 ~18 min android 📦 apk
✔️ c8a77f4 #8 2019-05-12 15:38:16 ~18 min android-e2e 📦 apk
✔️ c8a77f4 #8 2019-05-12 15:40:24 ~21 min macos 📦 dmg
✔️ c8a77f4 #8 2019-05-12 15:43:35 ~24 min ios 📦 ipa
✔️ c8a77f4 #10 2019-05-13 14:16:55 ~14 min linux 📦 App
✔️ c8a77f4 #10 2019-05-13 14:19:05 ~16 min android-e2e 📦 apk
✔️ c8a77f4 #10 2019-05-13 14:20:11 ~18 min android 📦 apk
✔️ c8a77f4 #10 2019-05-13 14:22:02 ~19 min macos 📦 dmg
✔️ c8a77f4 #10 2019-05-13 14:26:32 ~24 min ios 📦 ipa
✔️ c8a77f4 #10 2019-05-13 14:30:09 ~27 min windows 📦 exe
❔ Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ 7946bbf #9 2019-05-12 16:04:09 ~17 min linux 📦 App
✔️ 7946bbf #9 2019-05-12 16:04:53 ~18 min macos 📦 dmg
✔️ 7946bbf #9 2019-05-12 16:05:34 ~18 min windows 📦 exe
✔️ 7946bbf #9 2019-05-12 16:05:35 ~18 min android 📦 apk
✔️ 7946bbf #9 2019-05-12 16:05:41 ~18 min android-e2e 📦 apk
✔️ 7946bbf #9 2019-05-12 16:09:14 ~22 min ios 📦 ipa
❌ 74093f6 #11 2019-05-14 10:02:08 ~4 min ios 📄 log
✔️ 74093f6 #11 2019-05-14 10:14:58 ~17 min macos 📦 dmg
✔️ 74093f6 #11 2019-05-14 10:15:42 ~18 min linux 📦 App
✔️ 74093f6 #11 2019-05-14 10:15:53 ~18 min windows 📦 exe
✔️ 74093f6 #11 2019-05-14 10:20:15 ~22 min android 📦 apk
✔️ 74093f6 #11 2019-05-14 10:22:01 ~24 min android-e2e 📦 apk

@rasom rasom changed the title [iOS] Allow to send email with logs on iOS [wip] [iOS] Allow to send email with logs on iOS May 3, 2019
@status-github-bot status-github-bot bot moved this from REVIEW to CONTRIBUTOR in Pipeline for QA May 3, 2019
@rasom rasom force-pushed the logs-email-ios branch 3 times, most recently from 018bd8b to 7bd83af Compare May 6, 2019 06:21
mandrigin
mandrigin previously requested changes May 6, 2019
View reviewed changes
Copy link
Contributor

@mandrigin mandrigin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

a few questions

modules/react-native-status/ios/RCTStatus/RCTStatus.m

NSURL *dbFile = [logsFolderName URLByAppendingPathComponent:@"db.json"];
#if DEBUG
NSString *networkDirPath = @"ethereum/mainnet_rpc_dev";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hmm, why do we limit to mainnet only?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, till we fix that encoding in status-go api method. That’s rather temporary thing to make sure we get at least some data in email on iOS

modules/react-native-status/ios/RCTStatus/RCTStatus.m
#endif

NSURL *networkDir = [rootUrl URLByAppendingPathComponent:networkDirPath];
NSURL *originalGethLogsFile = [networkDir URLByAppendingPathComponent:@"geth.log"];
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why don't we use ExportNodeLogs here? https://github.com/status-im/status-go/blob/develop/mobile/status.go#L640

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because of encoding, I wrote on Friday, forgot to remind about this on call today

@dependency-lockfile-snitch
Copy link

mobile_files/yarn.lock changed. Pinging @jakubgs, @mandrigin, and @corpetty

@rasom rasom changed the title [wip] [iOS] Allow to send email with logs on iOS [iOS] Allow to send email with logs on iOS May 12, 2019
@rasom rasom mentioned this pull request May 12, 2019
Merged
@rasom rasom requested a review from flexsurfer May 13, 2019 08:22
@rasom rasom moved this from CONTRIBUTOR to E2E Tests in Pipeline for QA May 13, 2019
@statustestbot
Copy link

98% of end-end tests have passed

Total executed tests: 49
Failed tests: 1
Passed tests: 48

Failed tests (1)

Click to expand
1. test_send_stt_from_wallet

Device 1: Tap on SignTransactionButton
Device 1: Wait for GotItButton

Device 1: 'GotItButton' is not found on the screen

Device sessions

Passed tests (48)

Click to expand
1. test_block_user_from_public_chat
Device sessions

2. test_filters_from_daap
Device sessions

3. test_copy_and_paste_messages
Device sessions

4. test_send_transaction_from_daap
Device sessions

5. test_request_and_receive_tokens_in_1_1_chat
Device sessions

6. test_deploy_contract_from_daap
Device sessions

7. test_open_transaction_on_etherscan
Device sessions

8. test_public_chat_messaging
Device sessions

9. test_password_in_logcat_sign_in
Device sessions

10. test_text_message_1_1_chat
Device sessions

11. test_add_to_contacts
Device sessions

12. test_sign_typed_message (TestRail link is not found)
Device sessions

13. test_unread_messages_counter_1_1_chat
Device sessions

14. test_logcat_send_transaction_from_daap
Device sessions

15. test_send_message_in_group_chat
Device sessions

16. test_logcat_send_transaction_from_wallet
Device sessions

17. test_send_token_with_7_decimals
Device sessions

18. test_modify_transaction_fee_values
Device sessions

19. test_send_eth_from_wallet_to_address
Device sessions

20. test_manage_assets
Device sessions

21. test_logcat_send_transaction_in_1_1_chat
Device sessions

22. test_request_and_receive_eth_in_1_1_chat
Device sessions

23. test_swipe_to_delete_public_chat
Device sessions

24. test_send_emoji
Device sessions

25. test_search_chat_on_home
Device sessions

26. test_logcat_recovering_account
Device sessions

27. test_messaging_in_different_networks
Device sessions

28. test_send_tokens_in_1_1_chat
Device sessions

29. test_network_mismatch_for_send_request_commands
Device sessions

30. test_logcat_sign_message_from_daap
Device sessions

31. test_swipe_to_delete_1_1_chat
Device sessions

32. test_switch_users_and_add_new_account
Device sessions

33. test_send_eth_in_1_1_chat
Device sessions

34. test_login_with_new_account
Device sessions

35. test_send_eth_from_wallet_to_contact
Device sessions

36. test_add_contact_from_public_chat
Device sessions

37. test_send_two_transactions_one_after_another_in_dapp
Device sessions

38. test_password_in_logcat_creating_account
Device sessions

39. test_backup_recovery_phrase
Device sessions

40. test_offline_status
Device sessions

41. test_open_google_com_via_open_dapp
Device sessions

42. test_unread_messages_counter_public_chat
Device sessions

43. test_sign_message_from_daap
Device sessions

44. test_user_can_remove_profile_picture
Device sessions

45. test_share_contact_code_and_wallet_address
Device sessions

46. test_request_eth_in_wallet
Device sessions

47. test_refresh_button_browsing_app_webview
Device sessions

48. test_backup_recovery_phrase_warning_from_wallet
Device sessions

@churik churik self-assigned this May 13, 2019
@churik churik moved this from E2E Tests to IN TESTING in Pipeline for QA May 13, 2019
@statustestbot
Copy link

100% of end-end tests have passed

Total executed tests: 1
Failed tests: 0
Passed tests: 1

Passed tests (1)

Click to expand
1. test_send_stt_from_wallet
Device sessions

@churik
Copy link
Member

churik commented May 13, 2019

@rasom
tested on https://i.diawi.com/TBj6Ab
When extracting logs I see encrypted geth.log with error inside and db.json
Expected - Status.log and db.json
Logs: status_logs.zip](https://github.com/status-im/status-react/files/3173966/status_logs.zip)
OS: IOS 11.4.1 (IPhone 7)

@churik churik moved this from IN TESTING to REVIEW in Pipeline for QA May 13, 2019
@churik churik moved this from REVIEW to CONTRIBUTOR in Pipeline for QA May 13, 2019
@rasom
Copy link
Member Author

rasom commented May 14, 2019

@churik Status.log on iOS and Desktop is added in the separate pr #8081

@rasom
Copy link
Member Author

rasom commented May 14, 2019

When extracting logs I see encrypted geth.log

@churik are you sure you installed build №10? I can't reproduce it.

@churik churik moved this from CONTRIBUTOR to TO TEST in Pipeline for QA May 14, 2019
@churik churik moved this from TO TEST to IN TESTING in Pipeline for QA May 14, 2019
@churik
Copy link
Member

churik commented May 14, 2019

@rasom some glitch in #8124 (comment) (last builds were #9)
Tested on #10 build on IOS 11.4.1 (IPhone 7):

  • that can send logs (mail app is used, address in error-reports@status.im )
  • that can change log level, network settings and send logs;
  • .zip contains geth.log and db.json

Checked that doesn't affect to Android, so I can send logs.

@churik churik moved this from IN TESTING to MERGE in Pipeline for QA May 14, 2019
@rasom rasom merged commit 74093f6 into develop May 14, 2019
Pipeline for QA automation moved this from MERGE to DONE May 14, 2019
@delete-merged-branch delete-merged-branch bot deleted the logs-email-ios branch May 14, 2019 10:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cammellos cammellos cammellos approved these changes

@flexsurfer flexsurfer flexsurfer approved these changes

@mandrigin mandrigin Awaiting requested review from mandrigin

@pedropombeiro pedropombeiro Awaiting requested review from pedropombeiro

@dmitryn dmitryn Awaiting requested review from dmitryn

Assignees

@churik churik

Labels
Tested - OK
Projects
Pipeline for QA
  
DONE
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@rasom @status-im-auto @statustestbot @churik @mandrigin @cammellos @flexsurfer