Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Invalid passphrase for keycard multiacc #10409

Closed
rasom opened this issue Apr 22, 2020 · 1 comment · Fixed by #10415
Closed

Invalid passphrase for keycard multiacc #10409

rasom opened this issue Apr 22, 2020 · 1 comment · Fixed by #10415
Projects
Keycard

Comments

@rasom
Copy link
Member

rasom commented Apr 22, 2020 •
edited by StatusWrike
Loading

Problem

In case if multiacc creation is interrupted on seed phrase confirmation step an invalid seed phrase is shown when multiacc creation process is restarted.

Expected behavior

A valid phrase is shown

Actual behavior

Invalid phrase is shown

Reproduction

  1. Generate new keys
  2. Store on keycard
  3. Begin setup
  4. Create passcode
  5. Confirm passcode
  6. Press next on PUK/pairing screen
  7. Make screenshot of back up seed phrase
  8. Press cancel
  9. Begin setup again
  10. Confirm passcode
  11. Make screenshot of a new back up seed phrase
  12. Confirm phrase
  13. Reinstall app and try to restore multiacc using the second seed phrase
    (not necessarily keycard multiaccount)

Additional Information

  1. first phrase

  1. second phrase

  1. result on restoring
@rasom rasom added the bug label Apr 22, 2020
@rasom rasom self-assigned this Apr 22, 2020
@rasom
Copy link
Member Author

rasom commented Apr 22, 2020

@guylouis

@guylouis guylouis added this to HIGH in Keycard Apr 23, 2020
rasom added a commit that referenced this issue Apr 23, 2020
@rasom
[#10409] Invalid mnemonic on keycard acc creation
9d840f3 
Usage of `Keycard.generateMnemonic` is removed from the code as we
always generate new multiaccounts on status-go side. Previously it was
misused and was called with intention of generation of mnemonic for an
existing keycard multiacc.
rasom added a commit that referenced this issue Apr 23, 2020
@rasom
[#10409] Invalid mnemonic on keycard acc creation
2dd400f 
Usage of `Keycard.generateMnemonic` is removed from the code as we
always generate new multiaccounts on status-go side. Previously it was
misused and was called with intention of generation of mnemonic for an
existing keycard multiacc.
@rasom rasom mentioned this issue Apr 23, 2020
Merged
rasom added a commit that referenced this issue Apr 23, 2020
@rasom
[#10409] Invalid mnemonic on keycard acc creation
c805333 
Usage of `Keycard.generateMnemonic` is removed from the code as we
always generate new multiaccounts on status-go side. Previously it was
misused and was called with intention of generation of mnemonic for an
existing keycard multiacc.
@weekly-digest weekly-digest bot mentioned this issue Apr 26, 2020
Closed
@guylouis guylouis moved this from HIGH to CLOSED in Keycard Apr 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
Keycard
CLOSED
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[#10409] Invalid mnemonic on keycard acc creation status-im/status-mobile
1 participant
@rasom