Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#10044] Responsive new chat input #10046

Merged
merged 1 commit into from
Feb 14, 2020
Merged

[#10044] Responsive new chat input #10046

merged 1 commit into from
Feb 14, 2020

Conversation

rasom
Copy link
Contributor

@rasom rasom commented Feb 14, 2020 •
edited by StatusWrike
Loading

fix #10044

status: ready

@rasom rasom requested a review from a team as a code owner February 14, 2020 13:19
@auto-assign auto-assign bot removed the request for review from a team February 14, 2020 13:19
@status-github-bot
Copy link

Pull Request Checklist

  • Docs: Updated the documentation, if affected
  • Docs: Added or updated inline comments explaining intention of the code
  • Tests: Ensured that all new UI elements have been assigned accessibility IDs
  • Tests: Signaled need for E2E tests with label, if applicable
  • Tests: Briefly described what was tested and what platforms were used
  • UI: In case of UI changes, ensured that UI matches Figma
  • UI: In case of UI changes, requested review from a Core UI designer
  • UI: In case of UI changes, included screenshots of implementation

@rasom rasom self-assigned this Feb 14, 2020
@status-im-auto
Copy link
Member

status-im-auto commented Feb 14, 2020 •
edited
Loading

Jenkins Builds

❔ Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ 552a990 #1 2020-02-14 13:33:08 ~13 min ios 📦ipa 📲
✔️ 552a990 #1 2020-02-14 13:36:35 ~17 min android-e2e 📦apk 📲
❌ 552a990 #2 2020-02-14 15:37:30 ~3 min android 📄log
✔️ 3f6051c #2 2020-02-14 15:58:03 ~10 min ios 📦ipa 📲
✔️ 3f6051c #2 2020-02-14 16:02:38 ~15 min android-e2e 📦apk 📲
✔️ 3f6051c #3 2020-02-14 16:02:47 ~15 min android 📦apk 📲

@rasom rasom merged commit 3f6051c into develop Feb 14, 2020
@weekly-digest weekly-digest bot mentioned this pull request Feb 16, 2020
Closed
@rasom rasom deleted the fix/new-chat-input-#10044 branch February 25, 2020 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@flexsurfer flexsurfer flexsurfer approved these changes

@yenda yenda Awaiting requested review from yenda

@vitvly vitvly Awaiting requested review from vitvly

Assignees
No one assigned
Labels
None yet
Projects
No open projects
Legacy QA Automation Project
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make search new chat field responsive to edits to taps after invalid ENS searched
3 participants
@rasom @status-im-auto @flexsurfer