Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor copy changes wallet #10300

Merged
merged 1 commit into from
Apr 14, 2020
Merged

Minor copy changes wallet #10300

merged 1 commit into from
Apr 14, 2020

Conversation

hesterbruikman
Copy link
Contributor

Summary

Minor copy changes to wallet

  • Set default currency > Set currency
  • These three words prove that a transaction is safe. > You should see these 3 words before signing each transaction
  • You should see these words before signing each transaction. If you don’t, cancel and sign out. > If you see a different combination, cancel the transaction and sign out

Steps to test

Open Wallet
Tap overflow ...
View bottom sheet
Tap View signing phrase

@hesterbruikman hesterbruikman requested a review from a team as a code owner April 8, 2020 15:06
@status-github-bot
Copy link

Pull Request Checklist

  • Docs: Updated the documentation, if affected
  • Docs: Added or updated inline comments explaining intention of the code
  • Tests: Ensured that all new UI elements have been assigned accessibility IDs
  • Tests: Signaled need for E2E tests with label, if applicable
  • Tests: Briefly described what was tested and what platforms were used
  • UI: In case of UI changes, ensured that UI matches Figma
  • UI: In case of UI changes, requested review from a Core UI designer
  • UI: In case of UI changes, included screenshots of implementation

@status-github-bot status-github-bot bot added this to REVIEW in Pipeline for QA Apr 8, 2020
@status-im-auto
Copy link
Member

status-im-auto commented Apr 8, 2020 •
edited
Loading

Jenkins Builds

❔ Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ dd03573 #1 2020-04-08 15:14:33 ~7 min android 📦apk 📲
✔️ dd03573 #1 2020-04-08 15:15:19 ~8 min ios 📦ipa 📲
✔️ dd03573 #1 2020-04-08 15:16:22 ~9 min android-e2e 📦apk 📲

@hesterbruikman @flexsurfer
Minor copy changes wallet
75c5a13 
Set default currency > Set currency
These three words prove that a transaction is safe. > You should see these 3 words before signing each transaction
You should see these words before signing each transaction. If you don’t, cancel and sign out. > If you see a different combination, cancel the transaction and sign out

Signed-off-by: Andrey Shovkoplyas <motor4ik@gmail.com>
@flexsurfer flexsurfer merged commit 75c5a13 into develop Apr 14, 2020
Pipeline for QA automation moved this from REVIEW to DONE Apr 14, 2020
@delete-merged-branch delete-merged-branch bot deleted the hesterbruikman-patch-1 branch April 14, 2020 13:00
@weekly-digest weekly-digest bot mentioned this pull request Apr 19, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@flexsurfer flexsurfer flexsurfer approved these changes

@Ferossgp Ferossgp Awaiting requested review from Ferossgp

Assignees
No one assigned
Labels
None yet
Projects
Pipeline for QA
  
DONE
Pipeline for QA
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@hesterbruikman @status-im-auto @flexsurfer