You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prior to this commit sign-message-completed effect would always use
the wrong-password label for error handling. We now ensure that wrong-password
is only used in case the error in question has a code 5, which is
associated to unmatching passwords.
In any other case we'll use the message attached to the error.
Hey @PascalPrecht, and thank you so much for making your first pull request in status-react! ❤️ Please help us make your experience better by filling out this brief questionnaire https://goo.gl/forms/uWqNcVpVz7OIopXg2
@PascalPrecht We don't add e2e for every fix (they are fairly slow to run as they run on a different platform on emulators), if you feel this needs testing you can add some tests in clojure (they are unit/integration tests).
In case the feature needs e2e tests, generally is the test team that writes them and maintains them.
Prior to this commit `sign-message-completed` effect would always use
the `wrong-password` label for error handling. We now ensure that `wrong-password`
is only used in case the error in question has a code `5`, which is
associated to unmatching passwords.
In any other case we'll use the `message` attached to the `error`.
Fixesstatus-im#8275
Signed-off-by: Andrey Shovkoplyas <motor4ik@gmail.com>
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Prior to this commit
sign-message-completedeffect would always usethe
wrong-passwordlabel for error handling. We now ensure thatwrong-passwordis only used in case the error in question has a code
5, which isassociated to unmatching passwords.
In any other case we'll use the
messageattached to theerror.Fixes #8275