-
Notifications
You must be signed in to change notification settings - Fork 983
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix #8717 change ens welcome screen #10343
Conversation
Pull Request Checklist
|
Jenkins Builds
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @yenda, looks good!
@yenda we should wait for translations for other languages or can merge it as it is? |
99% of end-end tests have passed
Failed tests (1)Click to expand
Passed tests (90)Click to expand
|
@churik yeah I think there will be some issues with other languages showing the old labels and the new one will be in english, I think I will change the names of the labels so that it's all in english until it is translated |
From @rachelhamlin: Let's just go ahead and merge |
@churik @rachelhamlin ok so I changed the labels to use new ones, so that the old ones aren't mixed up with the new ones and show the wrong thing to the user. As a result they will see the welcome screen in english until translations are made |
100% of end-end tests have passed
Passed tests (91)Click to expand
|
Thank you @yenda. |
english only needs work for translations Signed-off-by: Andrea Maria Piana <andrea.maria.piana@gmail.com>
fixes #8717
english only
needs work for translations
status: ready