Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gradle: upgrade plugin to 3.6.0 #10387

Merged
merged 1 commit into from
Apr 21, 2020
Merged

gradle: upgrade plugin to 3.6.0 #10387

merged 1 commit into from
Apr 21, 2020

Conversation

jakubgs
Copy link
Member

@jakubgs jakubgs commented Apr 21, 2020 •
edited by StatusWrike
Loading

This is to fix incompatibility with new Gradle 5.6.4:
https://developer.android.com/studio/releases/gradle-plugin#updating-gradle

I missed this should be changed when upgrading Gradle in #10340.

Might help with #10375

@jakubgs jakubgs requested a review from a team as a code owner April 21, 2020 13:24
@jakubgs jakubgs self-assigned this Apr 21, 2020
@status-github-bot
Copy link

Pull Request Checklist

  • Docs: Updated the documentation, if affected
  • Docs: Added or updated inline comments explaining intention of the code
  • Tests: Ensured that all new UI elements have been assigned accessibility IDs
  • Tests: Signaled need for E2E tests with label, if applicable
  • Tests: Briefly described what was tested and what platforms were used
  • UI: In case of UI changes, ensured that UI matches Figma
  • UI: In case of UI changes, requested review from a Core UI designer
  • UI: In case of UI changes, included screenshots of implementation

@status-github-bot status-github-bot bot added this to REVIEW in Pipeline for QA Apr 21, 2020
@status-im-auto
Copy link
Member

status-im-auto commented Apr 21, 2020 •
edited
Loading

Jenkins Builds

Click to see older builds (2)
❔ Commit #️⃣ Finished (UTC) Duration Platform Result
❌ a7f6017 #1 2020-04-21 13:25:00 ~25 sec android-e2e 📄log
❌ a7f6017 #1 2020-04-21 13:25:01 ~22 sec android 📄log
❔ Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ 6747aa3 #2 2020-04-21 13:43:53 ~10 min ios 📦ipa 📲
✔️ 6747aa3 #2 2020-04-21 13:46:05 ~13 min android-e2e 📦apk 📲
✔️ 6747aa3 #2 2020-04-21 13:48:44 ~15 min android 📦apk 📲
✔️ 2e0f986 #3 2020-04-21 14:02:06 ~12 min ios 📦ipa 📲
✔️ 2e0f986 #3 2020-04-21 14:03:21 ~14 min android-e2e 📦apk 📲
✔️ 2e0f986 #3 2020-04-21 14:03:28 ~14 min android 📦apk 📲

@jakubgs jakubgs mentioned this pull request Apr 21, 2020
Closed
@jakubgs
gradle: upgrade plugin to 3.6.0
938f3df 
This is to fix incompatibility with new Gradle 5.6.4:
https://developer.android.com/studio/releases/gradle-plugin#updating-gradle

Signed-off-by: Jakub Sokołowski <jakub@status.im>
@jakubgs jakubgs merged commit 938f3df into develop Apr 21, 2020
Pipeline for QA automation moved this from REVIEW to DONE Apr 21, 2020
@delete-merged-branch delete-merged-branch bot deleted the upgrade-gradle-plugin branch April 21, 2020 20:30
@jakubgs jakubgs mentioned this pull request Apr 22, 2020
Closed
@weekly-digest weekly-digest bot mentioned this pull request Apr 26, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cammellos cammellos cammellos approved these changes

@flexsurfer flexsurfer Awaiting requested review from flexsurfer

@0x-r4bbit 0x-r4bbit Awaiting requested review from 0x-r4bbit

@rasom rasom Awaiting requested review from rasom

@yenda yenda Awaiting requested review from yenda

Assignees
No one assigned
Labels
android
Projects
Pipeline for QA
  
DONE
Pipeline for QA
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jakubgs @status-im-auto @cammellos