fix(wallet/accounts): don't store derived account when it exists in app db #10408
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Checklist
|
Jenkins Builds
|
flexsurfer
reviewed
Apr 22, 2020
| accounts (:multiaccount/accounts db)] | ||
| {::import-account-seed {:passphrase passphrase | ||
| :hashed-password hashed-password | ||
| :accounts accounts }})))) |
There was a problem hiding this comment.
a perfectionist is crying :)
There was a problem hiding this comment.
As mentioned in the Review Notes, I'm very happy to iterate over this and change it to make it more reframe-y. Thoughts?
There was a problem hiding this comment.
i mean formatting, and btw lint has failed
flexsurfer
approved these changes
Apr 22, 2020
|
and also this |
0x-r4bbit
force-pushed
the
fix/multiaccounts
branch
from
4a9d2ba
to
b321de4
Compare
|
Thanks for the pointer @flexsurfer totally forgot that |
99% of end-end tests have passedFailed tests (1)Click to expand
Passed tests (91)Click to expand |
0% of end-end tests have passedFailed tests (1)Click to expand
|
100% of end-end tests have passedPassed tests (1) |
|
Tested:
Looks good to me. |
…pp db As discussed in status-im#10326 and later in status-im/status-go#1939, it turns out that, when a user tries to add an account (from a seed phrase), while an account with the same address (that the seed phrase would result in) exists in the application state, the application would still go ahead and store the derived account in status-go. After that it still reports to the user that the 'Account already exits'. This commit ensures that Status doesn't try to store the derived account when the account already exists in the application database. Fixes status-im#10326 Signed-off-by: Andrey Shovkoplyas <motor4ik@gmail.com>
flexsurfer
force-pushed
the
fix/multiaccounts
branch
from
b321de4
to
3fce002
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
As discussed in #10326 and later in status-im/status-go#1939, it turns out
that, when a user tries to add an account (from a seed phrase), while an account
with the same address (that the seed phrase would result in) exists in the application
state, the application would still go ahead and store the derived account in
status-go.
After that it still reports to the user that the 'Account already exits'.
This commit ensures that Status doesn't try to store the derived account when
the account already exists in the application database.
Fixes #10326
Review notes
We need to check whether the address in question already exists in
multiaccount/accountsso we need access todbinsidederive-and-store-account. However since this is a normal function, that doesn't have access to it per se, I decided to pass downaccountsfrom the outside before the function is called in the first place.Wouldn't be surprised if there's a "cleaner" more re-frame-like way to do this.
Testing notes
Follow reproduction steps in #10326, should get expected results.