-
Notifications
You must be signed in to change notification settings - Fork 984
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bootnodes e2e #10412
Merged
Merged
Bootnodes e2e #10412
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
churik
commented
Apr 22, 2020
•
edited
Loading
edited
- Added missed space to all translations
- Added accessibility ids to bootnode screens
- Uncommented test with custom bootnode + added basic validation (corresponding TC will be deleted in testrail)
- added rooted_device_continue to sign_in method to avoid failures like https://ethstatus.testrail.net/index.php?/tests/view/1349162
Pull Request Checklist
|
Jenkins BuildsClick to see older builds (6)
|
70e000f
to
af9d91f
Compare
Serhy
approved these changes
Apr 23, 2020
99% of end-end tests have passed
Failed tests (1)Click to expand
Passed tests (91)Click to expand |
Serhy
approved these changes
Apr 23, 2020
67563d8
to
a79c134
Compare
Signed-off-by: Churikova Tetiana <churikova.tm@gmail.com>
a79c134
to
57f1303
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.