Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nix refactor of Android SDK derivation #10420

Merged
merged 3 commits into from
Apr 24, 2020
Merged

Conversation

jakubgs
Copy link
Member

@jakubgs jakubgs commented Apr 23, 2020

Refactoring Android SDK Nix derivation in preparation for a refactor of status-go derivations.

Since the SDK is used both in Android app build process and status-go build process I wanted to avoid importing it and passing it around via args explicitly. To do that I added our custom Android SDK+NDK to the pkgs which are passed around via callPackage implicitly.

I also did the same for xcodeWrapper by defining it as part of pkgs in nix/pkgs.nix.
And I removed some useless configuration for Buck which we don't use anymore.

And upgraded Nix from 2.3.2 to 2.3.4.

@status-github-bot
Copy link

Pull Request Checklist

  • Docs: Updated the documentation, if affected
  • Docs: Added or updated inline comments explaining intention of the code
  • Tests: Ensured that all new UI elements have been assigned accessibility IDs
  • Tests: Signaled need for E2E tests with label, if applicable
  • Tests: Briefly described what was tested and what platforms were used
  • UI: In case of UI changes, ensured that UI matches Figma
  • UI: In case of UI changes, requested review from a Core UI designer
  • UI: In case of UI changes, included screenshots of implementation

@status-im-auto
Copy link
Member

status-im-auto commented Apr 23, 2020

Jenkins Builds

Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ 3ee734f #2 2020-04-23 16:24:47 ~14 min ios 📦ipa 📲
✔️ 3ee734f #2 2020-04-23 16:27:57 ~18 min android-e2e 📦apk 📲
✔️ 3ee734f #2 2020-04-23 16:29:20 ~19 min android 📦apk 📲
✔️ e61febc #3 2020-04-24 07:57:03 ~13 min ios 📦ipa 📲
✔️ e61febc #3 2020-04-24 07:58:06 ~14 min android-e2e 📦apk 📲
✔️ e61febc #3 2020-04-24 07:58:08 ~14 min android 📦apk 📲

Signed-off-by: Jakub Sokołowski <jakub@status.im>
Signed-off-by: Jakub Sokołowski <jakub@status.im>
Signed-off-by: Jakub Sokołowski <jakub@status.im>
@jakubgs jakubgs merged commit e1eda36 into develop Apr 24, 2020
Pipeline for QA automation moved this from REVIEW to DONE Apr 24, 2020
@delete-merged-branch delete-merged-branch bot deleted the nix/refactor-android-sdk branch April 24, 2020 09:19
@Serhy
Copy link
Contributor

Serhy commented Apr 24, 2020

@jakubgs Android builds gives me the crash right after app launch (confirmed with Android 8 real device and Android 10 (emulator) with this PR build and now with develop:

Screenshot 2020-04-24 at 18 01 41

@jakubgs
Copy link
Member Author

jakubgs commented Apr 24, 2020

Damn.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

4 participants