-
Notifications
You must be signed in to change notification settings - Fork 983
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Nix refactor of Android SDK derivation #10420
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Checklist
|
808a72e
to
3ee734f
Compare
Jenkins Builds
|
cammellos
approved these changes
Apr 24, 2020
Signed-off-by: Jakub Sokołowski <jakub@status.im>
Signed-off-by: Jakub Sokołowski <jakub@status.im>
Signed-off-by: Jakub Sokołowski <jakub@status.im>
e61febc
to
e1eda36
Compare
@jakubgs Android builds gives me the crash right after app launch (confirmed with Android 8 real device and Android 10 (emulator) with this PR build and now with develop: |
Damn. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactoring Android SDK Nix derivation in preparation for a refactor of
status-go
derivations.Since the SDK is used both in Android app build process and
status-go
build process I wanted to avoid importing it and passing it around via args explicitly. To do that I added our custom Android SDK+NDK to thepkgs
which are passed around viacallPackage
implicitly.I also did the same for
xcodeWrapper
by defining it as part ofpkgs
innix/pkgs.nix
.And I removed some useless configuration for Buck which we don't use anymore.
And upgraded Nix from
2.3.2
to2.3.4
.