stbt auto-selftest: Pre-import stbt & dependencies for better performance #560
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ance Importing stbt + gstreamer bindings + opencv is slow. On Unix systems `multiprocessing.Pool` uses `fork` so by importing stbt first, these modules won't be imported from scratch in each subprocess. We use a different subprocess for each Python file that we analyse. This saves about 1 second on `tests/auto-selftest-example-test-pack`. The improvement will be even larger on test-packs with more Python files.
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Importing stbt + gstreamer bindings + opencv is slow. On Unix systems
multiprocessing.Poolusesforkso by importing stbt first, thesemodules won't be imported from scratch in each subprocess. We use a
different subprocess for each Python file that we analyse.
This saves about 1 second on
tests/auto-selftest-example-test-pack.The improvement will be even larger on test-packs with more Python
files.
This should also make
test_auto_selftest_cachingmore reliable.