Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement double factorial #44

Closed
kgryte opened this issue Dec 6, 2016 · 3 comments · Fixed by #1112
Closed

Implement double factorial #44

kgryte opened this issue Dec 6, 2016 · 3 comments · Fixed by #1112
Labels
difficulty: 1 Low degree of difficulty. Should be straightforward to implement and/or resolve. Feature Issue or pull request for adding a new feature. Math Issue or pull request specific to math functionality.
Projects
Features

Comments

@kgryte
Copy link
Member

kgryte commented Dec 6, 2016

Double factorial. @stdlib/math/base/special/double-factorial.
@kgryte kgryte added difficulty: 1 Low degree of difficulty. Should be straightforward to implement and/or resolve. Feature Issue or pull request for adding a new feature. Math Issue or pull request specific to math functionality. labels Dec 6, 2016
@chrisdamba
Copy link
Contributor

What name should the function have, factorial2 or doublefactorial ?

@kgryte
Copy link
Member Author

kgryte commented Dec 6, 2016

Let's follow Python and Mathematica and go with factorial2.

chrisdamba added a commit to chrisdamba/stdlib that referenced this issue Dec 7, 2016
@chrisdamba
WIP - implementing double factorial stdlib-js#44
1981a82
@chrisdamba chrisdamba mentioned this issue Dec 17, 2016
Closed
7 tasks
rreusser added a commit to rreusser/stdlib that referenced this issue May 6, 2017
@rreusser
Add double factorial
0dd33ce 
Partially resolves stdlib-js#44 by implementing the double factorial for
nonnegative integers by way of a lookup table.
rreusser added a commit to rreusser/stdlib that referenced this issue May 6, 2017
@rreusser
Add double factorial
025f8a0 
Partially resolves stdlib-js#44 by implementing the double factorial for
nonnegative integers by way of a lookup table.
rreusser added a commit to rreusser/stdlib that referenced this issue May 6, 2017
@rreusser
Add double factorial
64d4293 
Partially resolves stdlib-js#44 by implementing the double factorial for
nonnegative integers by way of a lookup table.
rreusser added a commit to rreusser/stdlib that referenced this issue May 7, 2017
@rreusser
Add factorial2
e70170c 
Partially resolves stdlib-js#44 by implementing the double factorial for
nonnegative integers by way of a lookup table.
rreusser added a commit to rreusser/stdlib that referenced this issue May 7, 2017
@rreusser
Add factorial2
255f520 
Partially resolves stdlib-js#44 by implementing the double factorial for
nonnegative integers by way of a lookup table.
@kgryte
Copy link
Member Author

kgryte commented Oct 5, 2018

@rreusser Did you ever make any headway on your implementation? Or stated otherwise, how close were you to finishing an implementation for factorial2?

@kgryte kgryte mentioned this issue Oct 24, 2023
Merged
1 task
kgryte added a commit that referenced this issue Nov 17, 2023
@rgizz @kgryte
feat: add math/base/special/factorial2
c0dab03 
Closes: #44
PR-URL: 	#1112
Co-authored-by: Athan Reines <kgryte@gmail.com>
Reviewed-by: Athan Reines <kgryte@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
difficulty: 1 Low degree of difficulty. Should be straightforward to implement and/or resolve. Feature Issue or pull request for adding a new feature. Math Issue or pull request specific to math functionality.
Projects
Features
In Progress
Milestone
No milestone
2 participants
@chrisdamba @kgryte