Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RFC]: Add C implementation for @stdlib/math/base/special/acoversin #776

Closed
3 tasks done
Pranavchiku opened this issue Dec 24, 2022 · 5 comments · Fixed by #1429
Closed
3 tasks done

[RFC]: Add C implementation for @stdlib/math/base/special/acoversin #776

Pranavchiku opened this issue Dec 24, 2022 · 5 comments · Fixed by #1429
Assignees
@aman-095
Labels
Accepted RFC feature request which has been accepted. C Issue involves or relates to C. difficulty: 2 May require some initial design or R&D, but should be straightforward to resolve and/or implement. Feature Issue or pull request for adding a new feature. Good First Issue A good first issue for new contributors! Math Issue or pull request specific to math functionality. Native Addons Issue involves or relates to Node.js native add-ons. priority: Normal Normal priority concern or feature request. RFC Request for comments. Feature requests and proposed changes.

Comments

@Pranavchiku
Copy link
Member

Pranavchiku commented Dec 24, 2022 •
edited

Description

This RFC proposes adding C implementation for @stdlib/math/base/special/acoversin.

#include "stdlib/math/base/special/asin.h"

double stdlib_base_acoversin( const double x ) { 
    return stdlib_base_asin( 1.0 - x );
}

Related Issues

None.

Questions

No.

Other

Reference package:

Checklist

  • I have read and understood the Code of Conduct.
  • Searched for existing issues and pull requests.
  • The issue name begins with RFC:.
@Pranavchiku Pranavchiku added RFC Request for comments. Feature requests and proposed changes. Feature Issue or pull request for adding a new feature. labels Dec 24, 2022
@Pranavchiku Pranavchiku mentioned this issue Dec 24, 2022
Open
@Pranavchiku Pranavchiku self-assigned this Dec 24, 2022
@Pranavchiku Pranavchiku added Enhancement Issue or pull request for enhancing existing functionality. Math Issue or pull request specific to math functionality. Native Addons Issue involves or relates to Node.js native add-ons. and removed Feature Issue or pull request for adding a new feature. labels Dec 24, 2022
@Pranavchiku Pranavchiku removed their assignment Dec 27, 2022
@Pranavchiku Pranavchiku added the Good First Issue A good first issue for new contributors! label Dec 27, 2022
@kgryte kgryte added Feature Issue or pull request for adding a new feature. Accepted RFC feature request which has been accepted. priority: Normal Normal priority concern or feature request. C Issue involves or relates to C. difficulty: 2 May require some initial design or R&D, but should be straightforward to resolve and/or implement. and removed Enhancement Issue or pull request for enhancing existing functionality. labels Feb 23, 2024
@PraneGIT
Copy link
Contributor

hey @kgryte @Pranavchiku I would like to work on this.

@Pranavchiku
Copy link
Member Author

Thanks for your interest, go ahead!

@aman-095
Copy link
Contributor

Hey @kgryte @Pranavchiku I would like to work on this.

@Pranavchiku
Copy link
Member Author

Go ahead once you address review at #1419.

@Pranavchiku
Copy link
Member Author

Feel free to open up a PR for this, thank you for your contributions!

@aman-095 aman-095 mentioned this issue Mar 1, 2024
Merged
1 task
@Pranavchiku Pranavchiku assigned aman-095 and unassigned PraneGIT Mar 1, 2024
Planeshifter pushed a commit that referenced this issue Mar 1, 2024
@aman-095
feat: add C implementation for math/base/special/acoversin
1096686 
PR-URL: #142
Closes: #776

Reviewed-by: Pranav <85227306+Pranavchiku@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aman-095 aman-095

Labels
Accepted RFC feature request which has been accepted. C Issue involves or relates to C. difficulty: 2 May require some initial design or R&D, but should be straightforward to resolve and/or implement. Feature Issue or pull request for adding a new feature. Good First Issue A good first issue for new contributors! Math Issue or pull request specific to math functionality. Native Addons Issue involves or relates to Node.js native add-ons. priority: Normal Normal priority concern or feature request. RFC Request for comments. Feature requests and proposed changes.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add C implementation for @stdlib/math/base/special/acoversin aman-095/stdlib
4 participants
@kgryte @Pranavchiku @aman-095 @PraneGIT