Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: update blas/ext/base/srev to follow current project conventions #1700

Merged
merged 1 commit into from
Mar 5, 2024

Conversation

Snehil-Shah
Copy link
Contributor

Resolves #1533

Description

What is the purpose of this pull request?

This pull request:

  • refactors blas/ext/base/srev to follow current project conventions

Related Issues

Does this pull request have any related issues?

This pull request:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.


@stdlib-js/reviewers

…ntions

Signed-off-by: Snehil Shah <130062020+Snehil-Shah@users.noreply.github.com>
@kgryte kgryte added Bug Something isn't working. Enhancement Issue or pull request for enhancing existing functionality. BLAS Issue or pull request related to Basic Linear Algebra Subprograms (BLAS). C Issue involves or relates to C. Native Addons Issue involves or relates to Node.js native add-ons. and removed Bug Something isn't working. labels Mar 5, 2024
Copy link
Member

@kgryte kgryte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Excellent work @Snehil-Shah!

@kgryte kgryte merged commit 7c23a54 into stdlib-js:develop Mar 5, 2024
7 checks passed
utkrs01 pushed a commit to utkrs01/stdlib that referenced this pull request Mar 7, 2024
…ntions

Closes: stdlib-js#1533
Ref: stdlib-js#1152
PR-URL: 	stdlib-js#1700
Reviewed-by: Athan Reines <kgryte@gmail.com>
Signed-off-by: Snehil Shah <130062020+Snehil-Shah@users.noreply.github.com>
@Snehil-Shah Snehil-Shah deleted the 1533-refactor branch April 26, 2024 12:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BLAS Issue or pull request related to Basic Linear Algebra Subprograms (BLAS). C Issue involves or relates to C. Enhancement Issue or pull request for enhancing existing functionality. Native Addons Issue involves or relates to Node.js native add-ons.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[RFC]: refactor blas/ext/base/srev to follow current project conventions
2 participants