feat: add C implementation for math/base/special/avercos
#1719
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Snehil Shah <130062020+Snehil-Shah@users.noreply.github.com>
Pranavchiku
requested changes
Mar 6, 2024
lib/node_modules/@stdlib/math/base/special/avercos/test/test.native.js
Outdated
Show resolved
Hide resolved
Signed-off-by: Pranav <85227306+Pranavchiku@users.noreply.github.com>
Signed-off-by: Pranav <85227306+Pranavchiku@users.noreply.github.com>
Pranavchiku
added
Feature
Pranavchiku
approved these changes
Mar 6, 2024
There was a problem hiding this comment.
Tested locally, everything works. Thanks for this @Snehil-Shah !
Planeshifter
approved these changes
Mar 6, 2024
utkrs01
pushed a commit
to utkrs01/stdlib
that referenced
this pull request
Mar 7, 2024
PR-URL: stdlib-js#1719 Closes: stdlib-js#1714 --------- Signed-off-by: Snehil Shah <130062020+Snehil-Shah@users.noreply.github.com> Signed-off-by: Pranav <85227306+Pranavchiku@users.noreply.github.com> Co-authored-by: Pranav <85227306+Pranavchiku@users.noreply.github.com> Reviewed-by: Pranav <85227306+Pranavchiku@users.noreply.github.com> Reviewed-by: Philipp Burckhardt <pburckhardt@outlook.com>
nishant-s7
pushed a commit
to nishant-s7/stdlib
that referenced
this pull request
Mar 7, 2024
PR-URL: stdlib-js#1719 Closes: stdlib-js#1714 --------- Signed-off-by: Snehil Shah <130062020+Snehil-Shah@users.noreply.github.com> Signed-off-by: Pranav <85227306+Pranavchiku@users.noreply.github.com> Co-authored-by: Pranav <85227306+Pranavchiku@users.noreply.github.com> Reviewed-by: Pranav <85227306+Pranavchiku@users.noreply.github.com> Reviewed-by: Philipp Burckhardt <pburckhardt@outlook.com>
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1714
Description
This pull request:
math/base/special/avercosRelated Issues
This pull request:
@stdlib/math/base/special/avercos#1714Questions
No.
Other
No.
Checklist
@stdlib-js/reviewers