Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add C implementation for math/base/assert/is-positive-integer #1780

Merged
merged 7 commits into from
Mar 8, 2024
Merged

feat: add C implementation for math/base/assert/is-positive-integer #1780

merged 7 commits into from
Mar 8, 2024

Conversation

Snehil-Shah
Copy link
Contributor

Resolves #1764

Description

What is the purpose of this pull request?

This pull request:

  • adds C implementation for math/base/assert/is-positive-integer

Related Issues

Does this pull request have any related issues?

This pull request:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

@stdlib-js/reviewers

@Snehil-Shah
feat: add C implementation for math/base/assert/is-positive-integer
4592d19 
Signed-off-by: Snehil Shah <130062020+Snehil-Shah@users.noreply.github.com>
@Snehil-Shah
fix: mistake in test name
232dfa1 
Signed-off-by: Snehil Shah <130062020+Snehil-Shah@users.noreply.github.com>
@Snehil-Shah
Update example.c
2bca015 
Signed-off-by: Snehil Shah <130062020+Snehil-Shah@users.noreply.github.com>
Pranavchiku
Pranavchiku requested changes Mar 8, 2024
View reviewed changes
Copy link
Member

@Pranavchiku Pranavchiku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Requested changes. Everything except addon.c seems fine. Once addressed this will be good to merge.

lib/node_modules/@stdlib/math/base/assert/is-positive-integer/README.md Show resolved Hide resolved
lib/node_modules/@stdlib/math/base/assert/is-positive-integer/README.md Outdated Show resolved Hide resolved
lib/node_modules/@stdlib/math/base/assert/is-positive-integer/examples/c/example.c Outdated Show resolved Hide resolved
lib/node_modules/@stdlib/math/base/assert/is-positive-integer/manifest.json Outdated Show resolved Hide resolved
lib/node_modules/@stdlib/math/base/assert/is-positive-integer/src/addon.c Outdated Show resolved Hide resolved
lib/node_modules/@stdlib/math/base/assert/is-positive-integer/src/main.c Show resolved Hide resolved
lib/node_modules/@stdlib/math/base/assert/is-positive-integer/src/main.c Outdated Show resolved Hide resolved
@Pranavchiku Pranavchiku added Feature Issue or pull request for adding a new feature. Native Addons Issue involves or relates to Node.js native add-ons. C Issue involves or relates to C. Needs Changes Pull request which needs changes before being merged. labels Mar 8, 2024
@Snehil-Shah
fix: suggestions
29cdafb 
Signed-off-by: Snehil Shah <130062020+Snehil-Shah@users.noreply.github.com>
@Snehil-Shah
Copy link
Contributor Author

@Pranavchiku did the needful👍

@Pranavchiku
chore: apply suggestions from code review
39fa5a2 
Signed-off-by: Pranav <85227306+Pranavchiku@users.noreply.github.com>
Pranavchiku
Pranavchiku approved these changes Mar 8, 2024
View reviewed changes
Copy link
Member

@Pranavchiku Pranavchiku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally, everything works well. Thanks @Snehil-Shah !

@Pranavchiku Pranavchiku added Ready to merge A pull request which is ready to be merged. and removed Needs Changes Pull request which needs changes before being merged. labels Mar 8, 2024
@kgryte
Apply suggestions from code review
04ad7c5 
Signed-off-by: Athan <kgryte@gmail.com>
@kgryte
Apply suggestions from code review
a40a625 
Signed-off-by: Athan <kgryte@gmail.com>
kgryte
kgryte approved these changes Mar 8, 2024
View reviewed changes
Copy link
Member

@kgryte kgryte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks, @Snehil-Shah!

@kgryte kgryte added the Math Issue or pull request specific to math functionality. label Mar 8, 2024
@kgryte kgryte merged commit 74866cb into stdlib-js:develop Mar 8, 2024
7 checks passed
@Snehil-Shah Snehil-Shah mentioned this pull request Mar 29, 2024
Closed
6 tasks
@Snehil-Shah Snehil-Shah deleted the issue1764-is-positive-integer branch April 26, 2024 12:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kgryte kgryte kgryte approved these changes

@Pranavchiku Pranavchiku Pranavchiku approved these changes

Assignees
No one assigned
Labels
C Issue involves or relates to C. Feature Issue or pull request for adding a new feature. Math Issue or pull request specific to math functionality. Native Addons Issue involves or relates to Node.js native add-ons. Ready to merge A pull request which is ready to be merged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[RFC]: add C implementation for @stdlib/math/base/assert/is-positive-integer
3 participants
@Snehil-Shah @kgryte @Pranavchiku