Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add C implementation for math/base/special/acsch #1833

Merged
merged 2 commits into from
Mar 11, 2024
Merged

feat: add C implementation for math/base/special/acsch #1833

merged 2 commits into from
Mar 11, 2024

Conversation

Snehil-Shah
Copy link
Contributor

Resolves #860

Description

What is the purpose of this pull request?

This pull request:

  • adds C implementation for math/base/special/acsch

Related Issues

Does this pull request have any related issues?

This pull request:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

@stdlib-js/reviewers

@Snehil-Shah
feat: add C implementation for math/base/special/acsch
854ab89 
Signed-off-by: Snehil Shah <130062020+Snehil-Shah@users.noreply.github.com>
@Planeshifter Planeshifter added Needs Review A pull request which needs code review. Native Addons Issue involves or relates to Node.js native add-ons. C Issue involves or relates to C. labels Mar 11, 2024
@kgryte kgryte added Math Issue or pull request specific to math functionality. Feature Issue or pull request for adding a new feature. labels Mar 11, 2024
@kgryte
Apply suggestions from code review
83c6aef 
Signed-off-by: Athan <kgryte@gmail.com>
kgryte
kgryte approved these changes Mar 11, 2024
View reviewed changes
Copy link
Member

@kgryte kgryte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks, @Snehil-Shah!

@kgryte kgryte removed the Needs Review A pull request which needs code review. label Mar 11, 2024
@kgryte kgryte merged commit 6e31e73 into stdlib-js:develop Mar 11, 2024
7 checks passed
gunjjoshi pushed a commit to gunjjoshi/stdlib that referenced this pull request Mar 20, 2024
@Snehil-Shah @kgryte @gunjjoshi
feat: add C implementation for math/base/special/acsch
f4c11a9 
Closes: stdlib-js#860
PR-URL: 	stdlib-js#1833
Co-authored-by: Athan Reines <kgryte@gmail.com>
Reviewed-by: Athan Reines <kgryte@gmail.com> 
Signed-off-by: Snehil Shah <130062020+Snehil-Shah@users.noreply.github.com>
Signed-off-by: Athan Reines <kgryte@gmail.com>
gunjjoshi pushed a commit to gunjjoshi/stdlib that referenced this pull request Mar 21, 2024
@Snehil-Shah @kgryte @gunjjoshi
feat: add C implementation for math/base/special/acsch
d313372 
Closes: stdlib-js#860
PR-URL: 	stdlib-js#1833
Co-authored-by: Athan Reines <kgryte@gmail.com>
Reviewed-by: Athan Reines <kgryte@gmail.com> 
Signed-off-by: Snehil Shah <130062020+Snehil-Shah@users.noreply.github.com>
Signed-off-by: Athan Reines <kgryte@gmail.com>
@Snehil-Shah Snehil-Shah mentioned this pull request Mar 29, 2024
Closed
6 tasks
@Snehil-Shah Snehil-Shah deleted the issue860-acsch branch April 26, 2024 12:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kgryte kgryte kgryte approved these changes

Assignees
No one assigned
Labels
C Issue involves or relates to C. Feature Issue or pull request for adding a new feature. Math Issue or pull request specific to math functionality. Native Addons Issue involves or relates to Node.js native add-ons.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[RFC]: Add C implementation for @stdlib/math/base/special/acsch
3 participants
@Snehil-Shah @kgryte @Planeshifter