Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement parse-dsv #246

Closed
wants to merge 70 commits into from
Closed

Implement parse-dsv #246

wants to merge 70 commits into from

Commits on Nov 5, 2018

  1. add rough working draft

    rmu committed Nov 5, 2018
    Configuration menu
    Copy the full SHA
    60181ef View commit details
    Browse the repository at this point in the history

  2. modify gitattributes to not normalize csv test data line endings

    rmu committed Nov 5, 2018
    Configuration menu
    Copy the full SHA
    ce46328 View commit details
    Browse the repository at this point in the history

  3. add and update for tests

    rmu committed Nov 5, 2018
    Configuration menu
    Copy the full SHA
    fb851ce View commit details
    Browse the repository at this point in the history

  4. change to incremental parser

    rmu committed Nov 5, 2018
    Configuration menu
    Copy the full SHA
    2a455e2 View commit details
    Browse the repository at this point in the history

  5. remove textdata check for now and reclarify

    rmu committed Nov 5, 2018
    Configuration menu
    Copy the full SHA
    2490ea1 View commit details
    Browse the repository at this point in the history

  6. consolidate tests

    rmu committed Nov 5, 2018
    Configuration menu
    Copy the full SHA
    23e05d0 View commit details
    Browse the repository at this point in the history

  7. add multichar delimitter handling

    rmu committed Nov 5, 2018
    Configuration menu
    Copy the full SHA
    45f86a2 View commit details
    Browse the repository at this point in the history

  8. another version of handling multichar delimiters

    rmu committed Nov 5, 2018
    Configuration menu
    Copy the full SHA
    e79c7e9 View commit details
    Browse the repository at this point in the history

  9. fix 1, handle 2, mitigate 3

    rmu committed Nov 5, 2018
    Configuration menu
    Copy the full SHA
    9d1d0a7 View commit details
    Browse the repository at this point in the history

  10. slightly cleaner

    rmu committed Nov 5, 2018
    Configuration menu
    Copy the full SHA
    00294d7 View commit details
    Browse the repository at this point in the history

  11. add weird test case

    rmu committed Nov 5, 2018
    Configuration menu
    Copy the full SHA
    46e8a10 View commit details
    Browse the repository at this point in the history

Commits on Nov 6, 2018

  1. only allow buffers or null

    rmu committed Nov 6, 2018
    Configuration menu
    Copy the full SHA
    8a1ddf6 View commit details
    Browse the repository at this point in the history

  2. add test for stream

    rmu committed Nov 6, 2018
    Configuration menu
    Copy the full SHA
    b40e78c View commit details
    Browse the repository at this point in the history

  3. update failing test case numbers

    rmu committed Nov 6, 2018
    Configuration menu
    Copy the full SHA
    9d3b87d View commit details
    Browse the repository at this point in the history

  4. update style for files in lib

    rmu committed Nov 6, 2018
    Configuration menu
    Copy the full SHA
    8780871 View commit details
    Browse the repository at this point in the history

  5. fix example in index.js

    rmu committed Nov 6, 2018
    Configuration menu
    Copy the full SHA
    90690c6 View commit details
    Browse the repository at this point in the history

  6. more formatting fixes

    rmu committed Nov 6, 2018
    Configuration menu
    Copy the full SHA
    bada739 View commit details
    Browse the repository at this point in the history

  7. suggested changes

    rmu committed Nov 6, 2018
    Configuration menu
    Copy the full SHA
    094299e View commit details
    Browse the repository at this point in the history

  8. add comments to explain each state

    rmu committed Nov 6, 2018
    Configuration menu
    Copy the full SHA
    8e44690 View commit details
    Browse the repository at this point in the history

  9. add end of stream token 

    also check row sizes
    rmu committed Nov 6, 2018
    Configuration menu
    Copy the full SHA
    1f07469 View commit details
    Browse the repository at this point in the history

  10. differentiate between quoted empty field and unquoted empty field

    rmu committed Nov 6, 2018
    Configuration menu
    Copy the full SHA
    90ef36a View commit details
    Browse the repository at this point in the history

  11. change to a class

    rmu committed Nov 6, 2018
    Configuration menu
    Copy the full SHA
    4c33b62 View commit details
    Browse the repository at this point in the history

  12. allow picking quote character

    rmu committed Nov 6, 2018
    Configuration menu
    Copy the full SHA
    2b209dc View commit details
    Browse the repository at this point in the history

  13. change tests so they pass

    rmu committed Nov 6, 2018
    Configuration menu
    Copy the full SHA
    271eea1 View commit details
    Browse the repository at this point in the history

Commits on Nov 7, 2018

  1. consolidate tests again

    rmu committed Nov 7, 2018
    Configuration menu
    Copy the full SHA
    d7ff7a0 View commit details
    Browse the repository at this point in the history

  2. add event emit test

    rmu committed Nov 7, 2018
    Configuration menu
    Copy the full SHA
    b092cba View commit details
    Browse the repository at this point in the history

  3. add error tests

    rmu committed Nov 7, 2018
    Configuration menu
    Copy the full SHA
    9f2ffcf View commit details
    Browse the repository at this point in the history

  4. sacrifice a bit of efficiency

    rmu committed Nov 7, 2018
    Configuration menu
    Copy the full SHA
    b109082 View commit details
    Browse the repository at this point in the history

  5. reordering cases

    rmu committed Nov 7, 2018
    Configuration menu
    Copy the full SHA
    9e79be2 View commit details
    Browse the repository at this point in the history

  6. a lot of things 

    options object

remove dsvState

add headers option

update tests
    rmu committed Nov 7, 2018
    Configuration menu
    Copy the full SHA
    b3de30c View commit details
    Browse the repository at this point in the history

  7. emit errors instead

    rmu committed Nov 7, 2018
    Configuration menu
    Copy the full SHA
    5f72e59 View commit details
    Browse the repository at this point in the history

  8. better way of quitting on error

    rmu committed Nov 7, 2018
    Configuration menu
    Copy the full SHA
    524e82d View commit details
    Browse the repository at this point in the history

  9. fix: row only emitted after another token was recieved

    rmu committed Nov 7, 2018
    Configuration menu
    Copy the full SHA
    6d18e58 View commit details
    Browse the repository at this point in the history

  10. suggested changes 

    add more tests
    rmu committed Nov 7, 2018
    Configuration menu
    Copy the full SHA
    29163ef View commit details
    Browse the repository at this point in the history

  11. naming changes

    rmu committed Nov 7, 2018
    Configuration menu
    Copy the full SHA
    2cd8de3 View commit details
    Browse the repository at this point in the history

  12. add rough delimiter guesser and tests

    rmu committed Nov 7, 2018
    Configuration menu
    Copy the full SHA
    4f73244 View commit details
    Browse the repository at this point in the history

Commits on Nov 8, 2018

  1. integrate delimiter guesser with dsvparser

    rmu committed Nov 8, 2018
    Configuration menu
    Copy the full SHA
    f9dd715 View commit details
    Browse the repository at this point in the history

  2. add functionality to delimiter guesser

    rmu committed Nov 8, 2018
    Configuration menu
    Copy the full SHA
    06dd5c2 View commit details
    Browse the repository at this point in the history

  3. undo gitattributes change

    rmu committed Nov 8, 2018
    Configuration menu
    Copy the full SHA
    f8c2ee1 View commit details
    Browse the repository at this point in the history

  4. add an error state

    rmu committed Nov 8, 2018
    Configuration menu
    Copy the full SHA
    66b7d1c View commit details
    Browse the repository at this point in the history

  5. refactoring and cleanup

    rmu committed Nov 8, 2018
    Configuration menu
    Copy the full SHA
    6864575 View commit details
    Browse the repository at this point in the history

  6. choose symbols over alphanumeric in delimiter guesser

    rmu committed Nov 8, 2018
    Configuration menu
    Copy the full SHA
    bc844fd View commit details
    Browse the repository at this point in the history

Commits on Nov 9, 2018

  1. maybe a cleaner way to avoid emitting

    rmu committed Nov 9, 2018
    Configuration menu
    Copy the full SHA
    bd15a01 View commit details
    Browse the repository at this point in the history

  2. test delimiter guesser on fixtures

    rmu committed Nov 9, 2018
    Configuration menu
    Copy the full SHA
    5135640 View commit details
    Browse the repository at this point in the history

Commits on Nov 10, 2018

  1. update error message

    rmu committed Nov 10, 2018
    Configuration menu
    Copy the full SHA
    15a9cba View commit details
    Browse the repository at this point in the history

  2. use better row count

    rmu committed Nov 10, 2018
    Configuration menu
    Copy the full SHA
    a20b9cd View commit details
    Browse the repository at this point in the history

  3. try to generate dsv data automatically for tests

    rmu committed Nov 10, 2018
    Configuration menu
    Copy the full SHA
    b891f8a View commit details
    Browse the repository at this point in the history

  4. style fixes

    rmu committed Nov 10, 2018
    Configuration menu
    Copy the full SHA
    ad9317e View commit details
    Browse the repository at this point in the history

  5. use regex to avoid quote problems

    rmu committed Nov 10, 2018
    Configuration menu
    Copy the full SHA
    83f8464 View commit details
    Browse the repository at this point in the history

  6. initial draft for README

    rmu committed Nov 10, 2018
    Configuration menu
    Copy the full SHA
    d04a671 View commit details
    Browse the repository at this point in the history

  7. add implementation specifics to README

    rmu committed Nov 10, 2018
    Configuration menu
    Copy the full SHA
    7b0215c View commit details
    Browse the repository at this point in the history

  8. small change to tests

    rmu committed Nov 10, 2018
    Configuration menu
    Copy the full SHA
    81e97dd View commit details
    Browse the repository at this point in the history

  9. add package.json

    rmu committed Nov 10, 2018
    Configuration menu
    Copy the full SHA
    98f7449 View commit details
    Browse the repository at this point in the history

Commits on Nov 11, 2018

  1. merge delimiter guessing into parser

    rmu committed Nov 11, 2018
    Configuration menu
    Copy the full SHA
    6a5e88a View commit details
    Browse the repository at this point in the history

  2. add delimiter guessing technique using quotes

    rmu committed Nov 11, 2018
    Configuration menu
    Copy the full SHA
    0c79142 View commit details
    Browse the repository at this point in the history

  3. merge options like other packages do 

    and some other lint fixes
    rmu committed Nov 11, 2018
    Configuration menu
    Copy the full SHA
    e384728 View commit details
    Browse the repository at this point in the history

  4. add docs for threshold option and fix typo

    rmu committed Nov 11, 2018
    Configuration menu
    Copy the full SHA
    d019437 View commit details
    Browse the repository at this point in the history

  5. add docs for properties and other small README fixes

    rmu committed Nov 11, 2018
    Configuration menu
    Copy the full SHA
    7cc88dc View commit details
    Browse the repository at this point in the history

Commits on Nov 13, 2018

  1. remove unnecessary check

    rmu committed Nov 13, 2018
    Configuration menu
    Copy the full SHA
    3eda29c View commit details
    Browse the repository at this point in the history

  2. suggested changes and other documentation updates 

    and small regex fixes
    rmu committed Nov 13, 2018
    Configuration menu
    Copy the full SHA
    483c600 View commit details
    Browse the repository at this point in the history

  3. minify fixtures

    rmu committed Nov 13, 2018
    Configuration menu
    Copy the full SHA
    6824033 View commit details
    Browse the repository at this point in the history

Commits on Nov 24, 2018

  1. delete manual delim guessing tests

    rmu committed Nov 24, 2018
    Configuration menu
    Copy the full SHA
    f4b50cc View commit details
    Browse the repository at this point in the history

  2. update last test to generate data with escaped quotes 

    and make comments start with uppercase
    rmu committed Nov 24, 2018
    Configuration menu
    Copy the full SHA
    c01bc21 View commit details
    Browse the repository at this point in the history

  3. update comments

    rmu committed Nov 24, 2018
    Configuration menu
    Copy the full SHA
    b5e13cd View commit details
    Browse the repository at this point in the history

  4. rename param in listener function for row event example

    rmu committed Nov 24, 2018
    Configuration menu
    Copy the full SHA
    5000b5a View commit details
    Browse the repository at this point in the history

  5. update examples in lib files

    rmu committed Nov 24, 2018
    Configuration menu
    Copy the full SHA
    7ad493e View commit details
    Browse the repository at this point in the history

  6. create examples

    rmu committed Nov 24, 2018
    Configuration menu
    Copy the full SHA
    7b60ec1 View commit details
    Browse the repository at this point in the history

  7. fix quotes in lib documentation

    rmu committed Nov 24, 2018
    Configuration menu
    Copy the full SHA
    32bd9ad View commit details
    Browse the repository at this point in the history

  8. add benchmarks

    rmu committed Nov 24, 2018
    Configuration menu
    Copy the full SHA
    0448d08 View commit details
    Browse the repository at this point in the history

  9. add docs

    rmu committed Nov 24, 2018
    Configuration menu
    Copy the full SHA
    2d315b4 View commit details
    Browse the repository at this point in the history