Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add lapack/base/dpttrf #2578

Open
wants to merge 11 commits into
base: develop
Choose a base branch
from
Open

feat: add lapack/base/dpttrf #2578

wants to merge 11 commits into from
+1,693 −0

Conversation

Pranavchiku
Copy link
Member

Towards #2464.

Description

What is the purpose of this pull request?

This pull request adds JS implementation for lapack/base/dpttrf.

Related Issues

Does this pull request have any related issues?

No.

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

@stdlib-js/reviewers

@Pranavchiku Pranavchiku added the LAPACK Issue or pull request related to the Linear Algebra Package (LAPACK). label Jul 13, 2024
Pranavchiku
Pranavchiku commented Jul 13, 2024
View reviewed changes
lib/node_modules/@stdlib/lapack/base/dpttrf/docs/repl.txt Outdated
Comment on lines 2 to 27
{{alias}}( N, D, E, info )
Computes the `L * D * L ** T` factorization of real symmetric positive
definite tridiagonal matrix `A`.

Indexing is relative to the first index. To introduce an offset, use typed
array views.

Parameters
----------

N: integer
Order of matrix `A`.

D: Float64Array
Diagonal elements of `A`.

E: Float64Array
Subdiagonal elements of `A`.

info: integer
Status code.

Returns
-------
info: integer
Status code.
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this and the equivalent for ndarray can be fairly automated, I'll just need the jsdoc or readme description and it will be done.

@Pranavchiku Pranavchiku mentioned this pull request Jul 13, 2024
Open
@kgryte kgryte added the Feature Issue or pull request for adding a new feature. label Jul 14, 2024
@kgryte kgryte added the Needs Changes Pull request which needs changes before being merged. label Jul 14, 2024
@Pranavchiku Pranavchiku marked this pull request as ready for review July 22, 2024 14:51
@Pranavchiku Pranavchiku added Needs Review A pull request which needs code review. and removed Needs Changes Pull request which needs changes before being merged. labels Jul 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kgryte kgryte kgryte left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
Feature Issue or pull request for adding a new feature. LAPACK Issue or pull request related to the Linear Algebra Package (LAPACK). Needs Review A pull request which needs code review.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Pranavchiku @kgryte