Angles laser beams evenly #182
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
That's true! Please add some boundary conditions check (namely when |
|
Thanks for the catch. Let me know if this looks alright to you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Laser beams are currently unevenly spaced because the code is dividing the total angle range by the number of rays rather than the number of spaces between rays (that is, rays - 1). Take, for example, the range [-45, 45] using 3 rays. The total angular range, 90, divided by 3, is 30. Beams will be placed at 0, 30, and 60. We want them placed at 0, 45, and 90, the result of dividing by rays - 1.