Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

can not load JSS with steal #1228

Closed
1 task done
pYr0x opened this issue Jul 25, 2017 · 1 comment
Closed
1 task done

can not load JSS with steal #1228

pYr0x opened this issue Jul 25, 2017 · 1 comment

Comments

@pYr0x
Copy link
Collaborator

pYr0x commented Jul 25, 2017

How often can you reproduce it?

  • Always

Description:
tried to load JSS https://github.com/cssinjs/jss

import jss from 'jss';
import preset from 'jss-preset-default';

in my index.js file.

Steps to reproduce:

  1. clone repo https://github.com/pYr0x/jss-steal-app/tree/jss-bug
  2. npm install
  3. open dev.html

Expected results:
all modules are loaded.

Actual results:
there is a problem with the module jss-global. the package.json is loaded correctly. this module tries to load jss in node_modules/jss-global/lib/index.js line 13.
jss-global defines jss as a peerDependency (see the package.json of jss-global). but i get an error that steal can not load the package.json of jss
http://localhost:63342/jss-steal-app/node_modules/jss-global/node_modules/jss/package.json
it seems that steal tries to load jss within jss-global folder. but thats not correct.

does steal not correctly handle peerDependencies?

Environment:

Software Version
Steal version 1.5.5
Steal-tools version 1.7.0
node -v 6
npm -v 3.10
Browser chrome
Operating system mac
@m-mujica
Copy link
Contributor

m-mujica commented Aug 1, 2017

looking into this...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants