Strict mode error in npm-crawl.js

[bmomberger-bitovi]

The line https://github.com/stealjs/steal/blob/master/ext/npm-crawl.js#L332 declares an auto-global variable v in a for...in loop. This breaks in strict mode, as v is not a previously defined name. This line should be for(var v in versions) {

[matthewp]

Thanks, this is clearly a bug, but did you see this happening some where? This file isn't strict mode so I wouldn't think that would occur, no?

[bmomberger-bitovi]

TIL that strict mode gets injected into files when using the --coverage flag in testee. A naive coverage configuration (which doesn't ignore anything by default) will inject strict into everything including steal's files.

A better issue title would state that npm-crawl places v on the global namespace.

[matthewp]

Oh, that's interesting. Possible testee bug I would think? cc @andrejewski There might be code (not this one) that needs to run in sloppy mode, but maybe there's a good reason for testee to do this?

[matthewp]

Also cc-ing @m-mujica on any ideas why our linting didn't catch this bug.