Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unable to load steal builtins #1428

Closed
matthewp opened this issue Jun 19, 2018 · 3 comments · Fixed by #1429
Closed

Unable to load steal builtins #1428

matthewp opened this issue Jun 19, 2018 · 3 comments · Fixed by #1429
Assignees
@matthewp
Labels
bug builtins node npm

Comments

@matthewp
Copy link
Member 

var util = require('util');

console.log(util);

Generates:

screen shot 2018-06-19 at 9 41 45 am

The problem code is here:

steal/ext/npm-crawl.js

Line 194 in fd4ae25

var stealPkg = utils.filter(deps, function(dep){

deps here is an object.
@matthewp matthewp self-assigned this Jun 19, 2018
matthewp added a commit that referenced this issue Jun 19, 2018
@matthewp
Correctly load steal's package.json for Node builtins
a49d119 
Loading Node builtins should happen automatically, because steal's own
package.json is loaded up-front. This fixes the behavior.

Closes #1428
@matthewp matthewp mentioned this issue Jun 19, 2018
Merged
@janat08
Copy link

janat08 commented Jun 19, 2018

how to upgrade to this?

@matthewp
Copy link
Member Author

Getting ready to release it.

@matthewp
Copy link
Member Author

1.12.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@matthewp matthewp

Labels
bug builtins node npm
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Correctly load steal's package.json for Node builtins stealjs/steal
2 participants
@matthewp @janat08