Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DynamicLogger does not work with Microsoft.Extensions.Logging 3.0 previews #90

Closed
TimHess opened this issue Aug 7, 2019 · 0 comments
Closed

DynamicLogger does not work with Microsoft.Extensions.Logging 3.0 previews #90

TimHess opened this issue Aug 7, 2019 · 0 comments
Assignees
@TimHess
Labels
Component/Logging Issues related to Dynamic Logging ReleaseLine/2.x Identified as a feature/fix for the 2.x release line ReleaseLine/3.x Identified as a feature/fix for the 3.x release line
Milestone
2.4.0-RC1

Comments

@TimHess
Copy link
Member

TimHess commented Aug 7, 2019

For version 3.0.0, Microsoft has marked ConsoleLogger and several related classes as internal, which breaks the current implementation of DynamicLogger.
@TimHess TimHess added ReleaseLine/3.x Identified as a feature/fix for the 3.x release line Component/Logging Issues related to Dynamic Logging labels Aug 7, 2019
@jkonicki jkonicki added this to the 3.0.0 milestone Aug 9, 2019
@TimHess TimHess self-assigned this Aug 14, 2019
@jkonicki jkonicki modified the milestones: 3.0.0, 2.3.1 Oct 16, 2019
@jkonicki jkonicki added the ReleaseLine/2.x Identified as a feature/fix for the 2.x release line label Oct 16, 2019
@TimHess TimHess mentioned this issue Oct 24, 2019
Merged
TimHess pushed a commit that referenced this issue Oct 25, 2019
Merge pull request #142 from SteeltoeOSS/netcoreapp3.0
ff0a94b 
Bring select changes from #94 into 2.x to add support for netcoreapp3, avoiding commits that remove .NET 4x -- closes #139, #127, #120, #90
@jkonicki jkonicki modified the milestones: 2.3.1, 2.4.0 Oct 25, 2019
@SteeltoeOSS SteeltoeOSS deleted a comment from cf-gitbot Apr 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@TimHess TimHess

Labels
Component/Logging Issues related to Dynamic Logging ReleaseLine/2.x Identified as a feature/fix for the 2.x release line ReleaseLine/3.x Identified as a feature/fix for the 3.x release line
Projects
None yet
Milestone
2.4.0-RC1
Development

No branches or pull requests
3 participants
@jkonicki @TimHess @cf-gitbot