1707 article page loading icon

[relativityboy]

#1707

Larger version of standard circle spinner displays for FullPost view when full post content is not available.

Also added a console command function that can be called to turn on & off logging of api calls.

Updated appearance after consulting with UI folks. No longer larger - now "blue" with white-space.

[sneak]

ideally this would be two separate PRs; we generally try to avoid multi-issue PRs (spinner plus konami code updates).

that said, this looks fine otherwise. utACK - test thoroughly before deploying.

[sneak]

utACK

[valzav]

I would keep the small spinner to make it consistent with other places where we have spinners. Also the small one from a design perspective is better - kind of less intrusive, especially on mobile.

[relativityboy]

@valzav - You do have some good points. I think the large one is consistent with our use case. It's the same spinner, scaled up appropriately.

Peripheral items are def worthy of smaller spinners. Because the article content is what people are looking for when they land on the page, it's good for them to see a larger indicator of progress. The small spinner can get 'lost'. Also, when the content does load, the vertical component of the page layout changes less, which is less jarring to the user. That means a more pleasant experience, and hopefully greater retention. (Users just wanna have fun!)

I imagine we'll eventually move from a very generic spinner to one that indicates the kind of content that's loading.

[valzav]

Yes I see the rationale behind making it bigger, maybe for the sake of consistency make all spinners slightly bigger? Also instead of passing styles into the component I would just pass a parameter saying 'please show a bigger version of the spinner' - this way it would be easier to reuse a bigger version.

[relativityboy]

And be more standard. Yeah.

[roadscape]

By my count we use LoadingIndicator in at least 15 places, are you suggesting to make all of them bigger?

[relativityboy]

@roadscape - I think a good interim would be to have a small/default (current) size, a medium, and a large size.

[roadscape]

I'd recommend to not change any existing spinners (it's a lot of testing and out of scope anyway) -- and yeah just add one or two predefined size-styles.

[pkattera]

The large spinner looks awkward and kinda exacerbates the misalignment of the heading to the tags and metadata below the empty page content. Let's go with the smaller sized spinner but to @relativityboy point, I'd be happy to increase the padding above and below the spinner so that the height taken up by the spinner area is about the same as in the screenshot above. To make it further more visually obvious, we could make the spinner blue?

[relativityboy]

Ok. Changes have been retested in dev. Looking good.

[roadscape]

IMO it looked better centered with more vertical padding. Although I'm finding it pretty hard to trigger this case and when I do the post loads pretty quick (even when I have Chrome throttle to 100kb/s and 1s latency).

[relativityboy]

@roadscape - I get where you're coming from on the centering, but pon called for it to be left aligned, so we're going with that.