Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Google AdSense Initial #3151

Merged
merged 3 commits into from
Jan 4, 2019
Merged

Google AdSense Initial #3151

merged 3 commits into from
Jan 4, 2019

Conversation

rjungemann
Copy link
Contributor

No description provided.

src/app/components/pages/PostsIndex.jsx Outdated Show resolved Hide resolved
@syvb
Copy link
Contributor

syvb commented Jan 4, 2019

I tried this code on my local Condenser instance, but all I see is an empty ins element instead of an ad. Why?
image
image

@wehmoen
Copy link
Contributor

wehmoen commented Jan 4, 2019

Google takes a while till it really shows ads on a page.

@syvb
Copy link
Contributor

syvb commented Jan 4, 2019

I looked into this, it seems like http://pagead2.googlesyndication.com/pagead/js/adsbygoogle.js is being blocked by the CSP.

Copy link
Contributor

@jredbeard jredbeard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ship it 👍

@rjungemann rjungemann merged commit f7a1ec7 into master Jan 4, 2019
@rjungemann rjungemann deleted the google-ads-initial-4 branch January 4, 2019 21:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants