Docs improvements #347
Merged
Docs improvements #347
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Set explicit coding language tags to all code blocks to improve syntax highlighting.
Plus various other minor spelling improvements.
Also minor formatting and spelling improvements.
Various other fixes
Documentation for: getTrendingTags, getHardforkVersion, getVestingDelegations, getWitnessByAccount Brief intro for: delegateVestingShares
added documentation for a lot of new methods & improved overall documentation style.
|
Can you update the PR a little to trigger rebuild? Looks like Circle failed for some other reason. It just needs to be rerun. |
|
👍 for this! |
Updates to fix minor issues with whitespace.
|
@r351574nc3 I've tried twice. The tests are failing checking the broadcast API. This might be related to the general instability/issues with the API nodes at present. |
|
So, I hold off until #350 is merged and then try again? |
|
Yes. The issues and PRs are now linked. I left a review on #350. I am positive once that is pulled, this can go in as well. |
ety001
approved these changes
Apr 22, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Siko91 and I have made some improvements to the Steem-js docs to try and make it easier to onboard new devs. The documentation improvements cover over 40 methods and incorporates our experiences in using those methods in our projects. We have left undocumented methods in place.