Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

7 Tests fixed. Issue #349 #350

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

7 Tests fixed. Issue #349 #350

wants to merge 1 commit into from

Conversation

BartolomeoItaliano
Copy link

@BartolomeoItaliano BartolomeoItaliano commented Feb 18, 2018 •
edited

@r351574nc3 r351574nc3 mentioned this pull request Feb 24, 2018
Merged
r351574nc3
r351574nc3 approved these changes Feb 25, 2018
View reviewed changes
Copy link

@r351574nc3 r351574nc3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good to me. New websocket URL is added to configuration. URI is left for backward-compatibility. Tests are passing.

@BartolomeoItaliano
Copy link
Author

How long it takes reviewers with write access to approve sth?
I am slowly thinking about forking library...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@r351574nc3 r351574nc3 r351574nc3 approved these changes

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@BartolomeoItaliano @r351574nc3