Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

expose memo ? #381

Merged
merged 2 commits into from
May 20, 2019
Merged

expose memo ? #381

merged 2 commits into from
May 20, 2019

Conversation

DoctorLai
Copy link
Contributor

memo is missing in steem.min.js

memo is missing in steem.min.js
@DoctorLai
Copy link
Contributor Author

@netuoso
Copy link
Contributor

netuoso commented May 20, 2019

Any reason there is no response or reply to this?

https://steemit.com/utopian-io/@justyy/steem-memo-not-present-in-the-steem-min-js-client-side

The above post, and this community PR, was made over a year ago. There is no risk involved. Instead, it makes the library more conformed across browser / node versions.

There's a comment on the above post made 6 hours ago showing users indeed require access to steem.memo via the CDN hosted steem.min.js

Copy link

@wehmoen wehmoen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@roadscape roadscape merged commit 9025d7c into steemit:master May 20, 2019
@DoctorLai
Copy link
Contributor Author

Nice!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants