Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Debug fixture shouldn't use debug_update() to create vests #2621

Closed
theoreticalbts opened this issue Jul 11, 2018 · 1 comment
Closed

Debug fixture shouldn't use debug_update() to create vests #2621

theoreticalbts opened this issue Jul 11, 2018 · 1 comment
Labels

Comments

@theoreticalbts
Copy link
Contributor

This code, which creates VESTS directly for unit tests, is creating false positives of the new rc_plugin code which finds unexpected changes to VESTS (which indicate a bug in the plugin).

So let's replace this method with a transfer from initminer followed by a normal vesting op.

One problem I encountered implementing this, is that some tests, e.g. withdraw_vesting_apply, will mix this method with other debug updates which causes the op to fail when the debug plugin re-pushes the op with less strict skip flags.

@mvandeberg
Copy link
Contributor

It turns out this solution is something I just came to as a work around to get tests working for #1770

mvandeberg pushed a commit that referenced this issue Jul 12, 2018
Don't use debug_update in vest() override #2621
@mac128k mac128k added the 0 label Jul 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants