Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use fixed_string_32 for custom operation ID's #3170

Closed
theoreticalbts opened this issue Nov 20, 2018 · 0 comments
Closed

Use fixed_string_32 for custom operation ID's #3170

theoreticalbts opened this issue Nov 20, 2018 · 0 comments
Assignees
@theoreticalbts
Labels
1 project/maintenance

Comments

@theoreticalbts
Copy link
Contributor

While working with the custom op infrastructure as part of #2705, I noticed the id string in custom binary / JSON ops could be replaced by fixed_string<32> which should avoid allocating memory when processing custom operations, and thus improve performance.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@theoreticalbts theoreticalbts

Labels
1 project/maintenance
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mac128k @theoreticalbts