Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

last_hardfork variable is int #485

Closed
theoreticalbts opened this issue Oct 4, 2016 · 1 comment
Closed

last_hardfork variable is int #485

theoreticalbts opened this issue Oct 4, 2016 · 1 comment

Comments

@theoreticalbts
Copy link
Contributor

Variable here is int, should be some fixed-size type, e.g. int64_t
@theoreticalbts
Copy link
Contributor Author

After reviewing the code and some consultation with @mvandeberg it seems the best option is uint32_t so that's what I'll do.

theoreticalbts added a commit that referenced this issue Oct 17, 2016
@theoreticalbts
Convert last_hardfork variable to uint32_t #485
b7dfeea
@theoreticalbts theoreticalbts mentioned this issue Oct 17, 2016
Merged
@theoreticalbts theoreticalbts mentioned this issue Oct 21, 2016
Closed
@mvandeberg mvandeberg mentioned this issue Oct 21, 2016
Closed
This was referenced Oct 28, 2016
Merged
Merged
On1x pushed a commit to VIZ-Blockchain/viz-cpp-node that referenced this issue May 28, 2018
@zxcat
Add logging config options to cli_wallet steemit#485
bbef791
On1x pushed a commit to VIZ-Blockchain/viz-cpp-node that referenced this issue May 28, 2018
@zxcat
cli_wallet logging: less vars steemit#485
7b74308
On1x pushed a commit to VIZ-Blockchain/viz-cpp-node that referenced this issue May 28, 2018
@zxcat
Unify logging options and simplify options code steemit#485
b866bf1 
1. Logger options use same syntax as other options (`--option=value`)
2. Unified options syntax (some had `--option value`)
3. Code style + some refactoring
On1x pushed a commit to VIZ-Blockchain/viz-cpp-node that referenced this issue May 28, 2018
@afalaleev
Merge pull request steemit#494 from zxcat/485-cli_wallet-logging
10a0f70 
Add logging options to cli_wallet steemit#485
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@theoreticalbts