Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review compile-time constants #510

Closed
theoreticalbts opened this issue Oct 14, 2016 · 3 comments
Closed

Review compile-time constants #510

theoreticalbts opened this issue Oct 14, 2016 · 3 comments
Assignees

Comments

@theoreticalbts
Copy link
Contributor

  • Make sure all testnet-specific code tests constant IS_TEST_NET
  • Make sure all testnet-specific code uses #if[n]def or #if defined()
  • Make sure Dockerfile explicitly specifies all "user-facing" configuration parameters
  • Document "user-facing" configuration parameters
@theoreticalbts theoreticalbts self-assigned this Oct 14, 2016
@theoreticalbts
Copy link
Contributor Author

The following compile-time constants seem to be related to the p2p code. I don't think any of them should be regarded as "user-facing" so I won't attempt to document them:

  • DEFAULT_LOGGER
  • ENABLE_P2P_DEBUGGING_API
  • P2P_IN_DEDICATED_THREAD
  • USE_PEERS_TO_DELETE_MUTEX
  • VERBOSE_NODE_DELEGATE_LOGGING

Does our p2p guru @emfrias have any opinion on the matter?

@theoreticalbts
Copy link
Contributor Author

The remaining options were already documented as part of #487. That means less work for me!

I'm removing all traces of ENABLE_CONTENT_PATCHING from the CMakeLists, Dockerfile and docs. It is not actually used, content patching is always enabled [1].

[1] Except when LOW_MEMORY_NODE is set. Since LOW_MEMORY_NODE throws away comment bodies, content patching doesn't even make sense in the context of LOW_MEMORY_NODE.

This was referenced Oct 14, 2016
This was referenced Oct 28, 2016
@theoreticalbts
Copy link
Contributor Author

Closing because it was merged.

On1x pushed a commit to VIZ-Blockchain/viz-cpp-node that referenced this issue May 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant