Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup Warnings #605

Closed
mvandeberg opened this issue Nov 23, 2016 · 1 comment
Closed

Cleanup Warnings #605

mvandeberg opened this issue Nov 23, 2016 · 1 comment
Assignees
@mvandeberg

Comments

@mvandeberg
Copy link
Contributor

Over time we have allowed a lot of warnings to show up during compilation. Many are benign, but we have discovered some nasty bugs through warnings recently. The code should be cleaned up to remove all warnings from the build process and CI should fail on a warning.
@mvandeberg mvandeberg self-assigned this Nov 23, 2016
mvandeberg pushed a commit that referenced this issue Nov 23, 2016
Cleanup steamed warnings #605
b7daf76
theoreticalbts added a commit that referenced this issue Nov 23, 2016
@theoreticalbts
More warning cleanup #605
632b187
theoreticalbts added a commit that referenced this issue Nov 23, 2016
@theoreticalbts
More warning cleanup #605
5d6cccf
theoreticalbts added a commit that referenced this issue Nov 23, 2016
@theoreticalbts
More warning cleanup #605
dd70695
theoreticalbts added a commit that referenced this issue Nov 23, 2016
@theoreticalbts
More warning cleanup #605
c411557
@mvandeberg mvandeberg mentioned this issue Nov 23, 2016
Merged
@theoreticalbts
Copy link
Contributor

This was merged, closing.

On1x pushed a commit to VIZ-Blockchain/viz-cpp-node that referenced this issue May 28, 2018
@afalaleev
Merge pull request steemit#605 from GolosChain/593-get-discussions-by…
aa01e2d 
…-author

Fix filtering in get_discussions_by_author_before_date(). steemit#593
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mvandeberg mvandeberg

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@theoreticalbts @mvandeberg