Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

debug_node wants but does not get sentinel value for reading blocks #606

Closed
theoreticalbts opened this issue Nov 23, 2016 · 2 comments
Closed

debug_node wants but does not get sentinel value for reading blocks #606

theoreticalbts opened this issue Nov 23, 2016 · 2 comments

Comments

@theoreticalbts
Copy link
Contributor

theoreticalbts commented Nov 23, 2016 •
edited
Loading

Warning with ~0 here led me to look at this code in debug_node. It seems to be expecting to get ~0 as a sentinel value for "I couldn't read a block" but the corresponding code in block_log.cpp here cannot produce such sentinel value. This issue merits further investigation.
@theoreticalbts
Copy link
Contributor Author

theoreticalbts commented Nov 23, 2016 •
edited
Loading

Further reading of the code shows that ~0 sentinel value is produced here and consumed here. This code should be clarified by using a named constant rather than a magic integer literal and a magic test.

@theoreticalbts theoreticalbts mentioned this issue Dec 9, 2016
Merged
theoreticalbts added a commit that referenced this issue Dec 9, 2016
@theoreticalbts
Explicitly name sentinel value #606
1a30d84
@theoreticalbts theoreticalbts mentioned this issue Dec 9, 2016
Closed
theoreticalbts added a commit that referenced this issue Dec 9, 2016
@theoreticalbts
Explicitly name sentinel value #606
cfc5d55
theoreticalbts added a commit that referenced this issue Dec 9, 2016
@theoreticalbts
Explicitly name sentinel value #606
fbbc80e
@theoreticalbts
Copy link
Contributor Author

Closing since this was merged.

On1x pushed a commit to VIZ-Blockchain/viz-cpp-node that referenced this issue May 28, 2018
@afalaleev
Fix start_author in get_discussions_by_comments. steemit#606
e5ddff8
On1x pushed a commit to VIZ-Blockchain/viz-cpp-node that referenced this issue May 28, 2018
@afalaleev
Merge pull request steemit#607 from GolosChain/606-get-discussions-by…
a8a0fe0 
…-comments

Fix start_author in get_discussions_by_comments. steemit#606
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@theoreticalbts