Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Possible to delete a post with historical payment? #876

Closed
abitmore opened this issue Feb 18, 2017 · 1 comment
Closed

Possible to delete a post with historical payment? #876

abitmore opened this issue Feb 18, 2017 · 1 comment
Assignees
@mvandeberg
Labels
HARDFORK
Milestone
0.19.0

Comments

@abitmore
Copy link
Contributor

If a post has no reply, after paid, its net_rshares is set to 0, so can be deleted.
@mvandeberg mvandeberg mentioned this issue Apr 11, 2017
Closed
@mvandeberg mvandeberg added this to the 0.19.0 milestone Apr 11, 2017
@mvandeberg mvandeberg self-assigned this Apr 21, 2017
@mvandeberg
Copy link
Contributor

mvandeberg commented Apr 21, 2017 •
edited
Loading

In order implement this change as described, we would need to make the non-consensus field total_payout_value consensus. Would it be acceptable to make posts that are 7 days old eligible for deletion regardless of payout?

mvandeberg pushed a commit that referenced this issue Apr 21, 2017
Prevent deleting a comment after payout and add tests for deleting co…
8583882 
…mments #876
mvandeberg pushed a commit that referenced this issue Apr 28, 2017
Prevent deleting a comment after payout and add tests for deleting co…
9c9d193 
…mments #876
mvandeberg pushed a commit that referenced this issue May 10, 2017
Prevent deleting a comment after payout and add tests for deleting co…
2317305 
…mments #876
mvandeberg pushed a commit that referenced this issue May 16, 2017
Prevent deleting a comment after payout and add tests for deleting co…
be045a8 
…mments #876
@mvandeberg mvandeberg mentioned this issue May 16, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mvandeberg mvandeberg

Labels
HARDFORK
Projects
None yet
Milestone
0.19.0
Development

No branches or pull requests
2 participants
@abitmore @mvandeberg