#801 remove children_rshares2 from consensus #1027

NateBrune · 2017-04-10T22:10:11Z

No description provided.

mvandeberg · 2017-04-12T16:00:34Z

On reindex

3415714ms th_a       database.cpp:2733             _apply_block         ] 10 assert_exception: Assert Exception
ctx.total_reward_shares2 > 0: 
    {}
    th_a  reward.cpp:12 get_rshare_reward

    {"ctx":{"rshares":"856788000000","reward_weight":10000,"max_sbd":"1000000.000 SBD","total_reward_shares2":"0","total_reward_fund_steem":"5778040.000 STEEM","current_steem_price":{"base":"0.220 SBD","quote":"1.000 STEEM"}}}
    th_a  reward.cpp:35 get_rshare_reward

    {"comment":{"id":9,"author":"abit","permlink":"spam","category":"","parent_author":"","parent_permlink":"","title":"Spams","body":"Spams come here","json_metadata":"{}","last_update":"2016-04-08T08:49:15","created":"2016-04-08T08:49:15","active":"2016-04-08T08:49:15","last_payout":"1970-01-01T00:00:00","depth":0,"children":0,"net_rshares":"856788000000","abs_rshares":"1610152000000","vote_rshares":"1233470000000","children_abs_rshares":1610152,"cashout_time":"2016-04-10T12:20:51","max_cashout_time":"2016-04-22T14:50:48","total_vote_weight":"723855738986","reward_weight":10000,"total_payout_value":"0.000 SBD","curator_payout_value":"0.000 SBD","beneficiary_payout_value":"0.000 SBD","author_rewards":0,"net_votes":-1,"root_comment":9,"max_accepted_payout":"1000000.000 SBD","percent_steem_dollars":10000,"allow_replies":true,"allow_votes":true,"allow_curation_rewards":true,"beneficiaries":[]}}
    th_a  database.cpp:1696 cashout_comment_helper
3415714ms th_a       database.cpp:2733             _apply_block         ] next_block.block_num(): 2889020

mvandeberg

Does not reindex

…nd undo regression from removing total_reward_shares2

mvandeberg · 2017-04-21T13:52:20Z

libraries/app/database_api.cpp

@@ -1526,7 +1526,7 @@ vector<discussion> database_api::get_discussions_by_cashout( const discussion_qu
      const auto& tidx = my->_db.get_index<tags::tag_index>().indices().get<tags::by_cashout>();
      auto tidx_itr = tidx.lower_bound( boost::make_tuple( tag, fc::time_point::now() - fc::minutes(60) ) );

-      return get_discussions( query, tag, parent, tidx, tidx_itr, query.truncate_body, []( const comment_api_obj& c ){ return c.children_rshares2 <= 0; } );
+      return get_discussions( query, tag, parent, tidx, tidx_itr, query.truncate_body, []( const comment_api_obj& c ) { return c.cashout_time <= c.created;  });


The lambda argument is a filter. If the filter lambda returns true then the comment is not returned. The previous filter was to remove all comments whose discussion had more negative rshares.

I would pass in filter_default for the filter arg and then make the exit arg []( const comment_api_obj& c ){ return c.net_rshares <= 0; } to stop returning results on negative payout posts.

mvandeberg · 2017-04-21T13:53:52Z

libraries/chain/steem_evaluator.cpp

@@ -1553,12 +1552,14 @@ void vote_evaluator::do_apply( const vote_operation& o )
         }
      });

+


Revert the line spacing changes in this file.

#801 remove children_rshares2 from consensus

d82cc14

mvandeberg suggested changes Apr 12, 2017

View reviewed changes

#801 Fix trending to use uint128, adjust get_discussion_by_cashout, a…

761e0ca

…nd undo regression from removing total_reward_shares2

mvandeberg suggested changes Apr 21, 2017

View reviewed changes

NateBrune added 2 commits April 25, 2017 15:27

#801 Adjust spacing, review get_discussion_by_cashout filter

38f8079

#801 Adjust filter to not exit early

2b4f091

mvandeberg approved these changes Apr 25, 2017

View reviewed changes

mvandeberg merged commit 36ee1b1 into master Apr 25, 2017

mvandeberg deleted the 801-remove-children-rshares2 branch April 25, 2017 20:13

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

#801 remove children_rshares2 from consensus #1027

#801 remove children_rshares2 from consensus #1027

NateBrune commented Apr 10, 2017

mvandeberg commented Apr 12, 2017

mvandeberg left a comment

mvandeberg Apr 21, 2017

mvandeberg Apr 21, 2017

		@@ -1553,12 +1552,14 @@ void vote_evaluator::do_apply( const vote_operation& o )
		}
		});

#801 remove children_rshares2 from consensus #1027

#801 remove children_rshares2 from consensus #1027

Conversation

NateBrune commented Apr 10, 2017

mvandeberg commented Apr 12, 2017

mvandeberg left a comment

Choose a reason for hiding this comment

mvandeberg Apr 21, 2017

Choose a reason for hiding this comment

mvandeberg Apr 21, 2017

Choose a reason for hiding this comment