Closes #2140 - Update SBD Print Rate

[mvandeberg]

Internal PR for #2503

Closes #2140

[TimCliff]

Just an update - I have started on fixes for the Boost test fixes here:
TimCliff@24fa7e9

After these changes however, it is failing on this:

/usr/local/src/steem/tests/tests/operation_time_tests.cpp(2771): fatal error in "sbd_stability": critical check db->get_account( "alice" ).sbd_balance + db->get_account( "alice" ).reward_sbd_balance == alice_sbd failed

I'm continuing to review.

[TimCliff]

Update: I resolved the failing test in my local branch. The constant in the comment_reward calculation needed to be updated to:

auto comment_reward = ( gpo.total_reward_fund_steem.amount + 85140 ) - ( ( gpo.total_reward_fund_steem.amount + 85140 ) * 25 * STEEM_1_PERCENT ) / STEEM_100_PERCENT ;

I am now working on the next failing test:
critical check db->get_dynamic_global_properties().sbd_print_rate < 10000 failed

[TimCliff]

I have this fixed on a local branch: https://github.com/TimCliff/steem/tree/2140-fix-boost-tests. I am just running some final tests before submitting a PR.

[theoreticalbts]

-      while( ( db->get_dynamic_global_properties().current_sbd_supply * exchange_rate ).amount >= ( db->get_dynamic_global_properties().virtual_supply.amount * STEEM_SBD_START_PERCENT ) / STEEM_100_PERCENT )
+      while( ( gpo.current_sbd_supply * exchange_rate ).amount >= ( gpo.virtual_supply.amount * gpo.sbd_start_percent ) / STEEM_100_PERCENT )

Blocks are produced inside this loop, which means you can't assume pointers to database objects (such as GPO) remain valid.

[TimCliff]

@theoreticalbts does adding back auto& gpo = db->get_dynamic_global_properties(); inside the loop resolve this?