Delegate to pool #2705 #3175
Closed
Delegate to pool #2705 #3175
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mvandeberg
reviewed
Nov 21, 2018
libraries/chain/steem_evaluator.cpp
Outdated
| @@ -2019,6 +2019,8 @@ void custom_json_evaluator::do_apply( const custom_json_operation& o ) | |||
| { | |||
| database& d = db(); | |||
|
|
|||
| ilog( "custom_json_evaluator is_producing = ${p} operation = ${o}", ("p", d.is_producing())("o", o) ); | |||
There was a problem hiding this comment.
Are these log messages intended for release or are they there from debugging?
mvandeberg
reviewed
Nov 21, 2018
| }; | ||
|
|
||
| /** | ||
| * Represents the total amount of an asset delegated by a user. |
There was a problem hiding this comment.
Are we allowing other types of staked assets to contribute to RCs? I know we planned to allow users to delegate to SMTs to fund emissions and other automated actions.
mvandeberg
reviewed
Nov 21, 2018
| * The delegated SP no longer generates RC for from_account, instead it generates | ||
| * RC for to_pool. | ||
| * | ||
| * Each SMT delegated to an account forms its own pool. Each account has only 3 |
There was a problem hiding this comment.
How is SMT delegation a part of RCs?
|
Closing in favor of #3438 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2705.