Fix sbd print rate #3415
Fix sbd print rate #3415
Conversation
libraries/chain/database.cpp
Outdated
| @@ -3901,9 +3900,15 @@ void database::update_virtual_supply() | |||
| auto percent_sbd = uint16_t( ( ( fc::uint128_t( ( dgp.current_sbd_supply * get_feed_history().current_median_history ).amount.value ) * STEEM_100_PERCENT ) | |||
There was a problem hiding this comment.
It looks like this statement would be unnecessary after hardfork 21 and should probably go in an else statement.
| } | ||
| else | ||
| { | ||
| percent_sbd = uint16_t( ( ( fc::uint128_t( ( dgp.current_sbd_supply * get_feed_history().current_median_history ).amount.value ) * STEEM_100_PERCENT ) |
There was a problem hiding this comment.
What about the HF20 behavior? It looks like it isn't happening here?
There was a problem hiding this comment.
The else block is the HF 20 behavior. What about this looks wrong to you?
There was a problem hiding this comment.
The buffer of 5 for the stop print rate gap that was specific to HF20. And then HF19 had that parameter set to zero. Isn't this going to behave differently for the HF20 blocks?
There was a problem hiding this comment.
This buffer of 5 was only for the HF21. Not present in HF20 or HF19.
There was a problem hiding this comment.
Ah that's what I was missing. Thanks!
Closes #3409
Local PR for #3410